rohanpm / kobo

53%

master: 49%

LAST BUILD ON BRANCH logging-thread-recover

branch: logging-thread-recover

CHANGE BRANCH

x

Reset

• logging-thread-recover
• 0.8.0
• fix-middleware-compat
• fork-task-log-exceptions
• logging-thread-py3
• middleware-TypeError
• refactored-gssapi
• release-via-travis
• remove-auto-logout
• retire-content-delivery-release-bot
• test-improvements

Build # 18

Build Type

push

travis-ci

Committed by rohanpm

Commit Message

Make LoggingThread recover on all errors

Previously, LoggingThread would recover from any XML-RPC fault,
but would stop when any other type of exception was encountered.
That is a problem, as it means the worker will permanently give
up sending messages to the hub when all kinds of temporary
issues occur (e.g. a temporary network disruption between worker
and hub). The task underneath may continue running for hours,
with all log messages being discarded.

Given the nature of this thread, it makes more sense to attempt
recovering from *all* kinds of errors, as we should try hard not
to lose log messages from a task.

Fixes #60

Run Details

3123 of 5926 relevant lines covered (52.7%)

0.53 hits per line