• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

rohanpm / kobo
50%
master: 49%

Build:
Build:
LAST BUILD BRANCH: remove-auto-logout
DEFAULT BRANCH: master
Repo Added 06 Oct 2018 07:15AM UTC
Files 109
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-middleware-compat
branch: fix-middleware-compat
CHANGE BRANCH
x
Reset
  • fix-middleware-compat
  • 0.8.0
  • fork-task-log-exceptions
  • logging-thread-py3
  • logging-thread-recover
  • middleware-TypeError
  • refactored-gssapi
  • release-via-travis
  • remove-auto-logout
  • retire-content-delivery-release-bot
  • test-improvements

pending completion
24

push

travis-ci

rohanpm
Fix backwards-incompatible MIDDLEWARE check

The logic here was: if Django 1.10 or greater is used, then
check the MIDDLEWARE variable.  Else check MIDDLEWARE_CLASSES.

This isn't correct, as Django 1.10 added support for MIDDLEWARE
but did not remove support for MIDDLEWARE_CLASSES.  This was a
backwards-incompatible change, as an application using
MIDDLEWARE_CLASSES could work fine on kobo 0.14.0 but would start
crashing on kobo 0.15.0, for no good reason.

Fix it so it's backwards-compatible. There are Django versions
supporting both MIDDLEWARE or MIDDLEWARE_CLASSES, so the only way
we can know which one to check is to probe which one has been
defined.

3059 of 6120 relevant lines covered (49.98%)

0.5 hits per line

Relevant lines Covered
Build:
Build:
6120 RELEVANT LINES 3059 COVERED LINES
0.5 HITS PER LINE
Source Files on fix-middleware-compat
  • Tree
  • List 109
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
24 fix-middleware-compat Fix backwards-incompatible MIDDLEWARE check The logic here was: if Django 1.10 or greater is used, then check the MIDDLEWARE variable. Else check MIDDLEWARE_CLASSES. This isn't correct, as Django 1.10 added support for MIDDLEWARE but did not re... push 25 Jun 2020 11:06PM UTC rohanpm travis-ci pending completion  
See All Builds (15)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc