raystack / frontier
42%
main: 44%

Repo Added 27 Jul 2023 06:58AM UTC

Token xRqMBdQBcqmLktLNAeQpRpj0YfJbkFc6Q regen

Build 5177 Last

Committed 14 May 2026 04:58AM UTC coverage: 42.286% (+0.04%) from 42.249%

Committed by

Commit Message

fix(group): map AddGroupUsers errors instead of returning Internal

The handler previously collapsed every per-user failure into a generic
CodeInternal response, hiding actionable information like group/user
not found, not-org-member, or last-owner. Adds the same error-mapping
switch SetGroupMemberRole uses, applied to the joined error.

errors.Is walks errors.Join trees, so if multiple users failed with
different errors the first matching case wins. The caller still can't
tell which user failed (the proto response is empty), but at least the
error code reflects something useful when all failures share a cause —
which is the common case for single-user adds.

New handler tests cover the new mapped cases.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

35 of 41 new or added lines in 3 files covered. (85.37%)

6 existing lines in 1 file now uncovered.

15892 of 37582 relevant lines covered (42.29%)

11.89 hits per line

37582 RELEVANT LINES 15892 COVERED LINES

11.89 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
25842616411	refactor/addgroupusers-via-membership	fix(group): map AddGroupUsers errors instead of returning Internal The handler previously collapsed every per-user failure into a generic CodeInternal response, hiding actionable information like group/user not found, not-org-member, or last-owne...	Pull #1608	14 May 2026 05:03AM UTC	whoAbhishekSah	github	42.29
25841154041	refactor/addgroupusers-via-membership	fix(membership): atomic last-owner guard for SetGroupMemberRole Applies the same TOCTOU fix from #1590 to the group path: - validateMinGroupOwnerConstraint now returns the resolved group owner role ID alongside the error. - SetGroupMemberRole ...	Pull #1608	14 May 2026 04:15AM UTC	whoAbhishekSah	github	42.27
25840986421	refactor/addgroupusers-via-membership	test(e2e): add user to org before adding to group After the AddGroupUsers handler now routes through SetGroupMemberRole, the org-membership check fires on the add path. Tests that previously added a freshly-created user directly to a group must f...	Pull #1608	14 May 2026 04:09AM UTC	whoAbhishekSah	github	42.26
25840906325	refactor/addgroupusers-via-membership	test(e2e): add user to org before adding to group After the AddGroupUsers handler now routes through SetGroupMemberRole, the org-membership check fires on the add path. Tests that previously added a freshly-created user directly to a group must f...	Pull #1608	14 May 2026 04:06AM UTC	whoAbhishekSah	github	42.26
25840522774	refactor/addgroupusers-via-membership	refactor(membership): collapse AddGroupMember into SetGroupMemberRole After the SetGroupMemberRole upsert in #1603, AddGroupMember and the add-path of SetGroupMemberRole did the same work. The three callers (OnGroupCreated, AddGroupUsers handler,...	Pull #1608	14 May 2026 03:53AM UTC	whoAbhishekSah	github	42.26
25839704038	refactor/addgroupusers-via-membership	refactor(group): migrate AddGroupUsers handler to membership The AddGroupUsers RPC handler now loops membershipService.AddGroupMember instead of calling the legacy groupService.AddUsers, which is removed along with AddMember and addMemberPolicy. ...	Pull #1608	14 May 2026 03:25AM UTC	whoAbhishekSah	github	42.31

raystack / frontier
42%
main: 44%

raystack / frontier 42% main: 44%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on refactor/addgroupusers-via-membership

Recent builds

raystack / frontier
42%
main: 44%

README BADGES
x

CHANGE BRANCH
x