raystack / frontier / 25842616411

42%

main: 42%

Build Type

Pull #1608

github

Committed by whoAbhishekSah

Commit Message

fix(group): map AddGroupUsers errors instead of returning Internal

The handler previously collapsed every per-user failure into a generic
CodeInternal response, hiding actionable information like group/user
not found, not-org-member, or last-owner. Adds the same error-mapping
switch SetGroupMemberRole uses, applied to the joined error.

errors.Is walks errors.Join trees, so if multiple users failed with
different errors the first matching case wins. The caller still can't
tell which user failed (the proto response is empty), but at least the
error code reflects something useful when all failures share a cause —
which is the common case for single-user adds.

New handler tests cover the new mapped cases.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #1608: refactor(group): migrate AddGroupUsers handler to membership

Coverage Stats

35 of 41 new or added lines in 3 files covered. (85.37%)

6 existing lines in 1 file now uncovered.

15892 of 37582 relevant lines covered (42.29%)

11.89 hits per line