rayslava / revdiff

92%

master: 92%

LAST BUILD ON BRANCH feat/herdr-pane-overlay

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• feat/herdr-pane-overlay

Build # 33544414712

Build Type

push

github

Committed by rayslava

Commit Message

feat(launcher): herdr pane-scoped overlay (REVDIFF_HERDR_PANE=1)

under herdr a review replaces the whole tab view, so the agent pane that asked for it disappears for as long as the review lasts. herdr's working layout is an agent in one pane and you beside it, but the backend only ever calls `herdr tab create` + `pane run`, and the agent's pane holds the context the diff has to be judged against. `REVDIFF_AGTERM_PANE=1` already exists for the same reason on agterm, which has the same layout model.

`REVDIFF_HERDR_PANE=1` splits the caller's own pane and zooms it, so the review still gets the full tab area but the agent pane is one keypress away. it copies the shape agterm settled on: env-var opt-in, capability probe before passing a new flag, quiet degradation to the existing overlay. unset, the `tab create` block is reached byte-identical, because pane mode is a self-contained block ahead of it rather than a flag threaded through the shared path.

owning a pane means owning its teardown, and the rules are recorded in CLAUDE.md because none of them are guessable from the code alone:

- never guess which pane to close. a split that returns no usable pane id warns and exits rather than diffing `pane list`, since a recovered id may belong to another herdr client.
- `pane_not_found` is authoritative death; any other error is transient, so the wait loop keeps polling with a backoff rather than treating an unreachable control plane as a dead review.
- cleanup is decided by evidence from the pane, not by `pane run` returning. the dispatched script touches a marker, ownership is claimed before the call, and unknown state is preserved rather than destroyed -- a launcher killed on timeout leaves a live review open with nothing lost.
- a trapped signal is deferred until the in-flight command returns and then runs before the next statement, so the windows where a pane exists but is not yet named record the signal instead of exiting on it, and pay it once ownersh... (continued)

Coverage Stats

11821 of 12919 relevant lines covered (91.5%)

3457.68 hits per line