rayslava / revdiff / 33396147693
92%
master: 92%

LAST BUILD BRANCH: feat/herdr-pane-overlay
DEFAULT BRANCH: master
Ran
Jobs 1
Files 79
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.498%. First build
33396147693

push

github

rayslava 
feat(launcher): herdr pane-scoped overlay (REVDIFF_HERDR_PANE=1)

opt-in pane overlay for herdr, mirroring the existing REVDIFF_AGTERM_PANE=1. Unset, the `herdr tab create` + `pane run` fullscreen-tab path runs exactly as before, and the tab block is reached byte-identical to HEAD.

**pane mode.** `REVDIFF_HERDR_PANE=1` splits the caller's own pane and zooms it, so the agent pane stays one keypress away instead of being replaced by a new tab. It is a self-contained block ahead of the tab path (probe, split, zoom, run, wait, close, exit), which is what keeps the default path untouched; the cost is a short duplicated exit tail, matching the precedent in `launch-plan-review.sh`. The capability probe covers `pane split`/`get`/`close` because all three are used at runtime, and any failure before the split degrades quietly to the tab overlay.

**never guess which pane to close.** If `pane split` reports success but returns no parseable id, the launcher warns and exits 1 rather than diffing `pane list` to find the pane. A set difference is not deletion authority: the pane population can change between the split and the cleanup, so a recovered id may belong to another herdr client and closing it would destroy someone else's work. The same rule rejects a returned id equal to the caller's own pane, which the positional grep fallback can otherwise produce on a jq-less box.

**liveness.** The wait loop treats `{"error":{"code":"pane_not_found"}}` as authoritative death, so nothing is closed and nothing is warned about on the ordinary "user closed the review pane" path. Any other error is transient: bounded at 10 misses so the loop cannot hang, but ownership is kept so teardown still attempts the close.

*note: do not bracket the create window with `trap '' INT TERM` to close the residual signal gap. `trap ''` is SIG_IGN, which is inherited across `exec`, so the herdr child ignores INT/TERM too and a hung server leaves the launcher unkillable by anything but SIGKI... (continued)

11816 of 12914 relevant lines covered (91.5%)

3458.97 hits per line

Jobs
ID Job ID Ran Files Coverage
1 33396147693.1 79
91.5
 GitHub Action Run
Source Files on build 33396147693