preactjs / preact

100%

master: 100%

LAST BUILD ON BRANCH force-mobx

branch: force-mobx

CHANGE BRANCH

x

Reset

• force-mobx
• 10.0.0
• 10.0.0-beta.2
• 10.0.0-beta.3
• 10.0.0-rc.0
• 10.0.0-rc.1
• 10.0.0-rc.2
• 10.0.0-rc.3
• 10.0.1
• 10.0.2
• 10.0.3
• 10.0.4
• 10.0.5
• 10.1.0
• 10.1.1
• 10.14.1
• 10.15.0
• 10.15.1
• 10.16.0
• 10.17.0
• 10.17.1
• 10.18.0
• 10.18.1
• 10.18.2
• 10.19.0
• 10.19.1
• 10.19.2
• 10.19.3
• 10.19.4
• 10.19.5
• 10.19.6
• 10.19.7
• 10.2.0
• 10.2.1
• 10.20.0
• 10.20.1
• 10.20.2
• 10.21.0
• 10.22.0
• 10.22.1
• 10.23.0
• 10.23.1
• 10.23.2
• 10.24.0
• 10.24.1
• 10.24.2
• 10.24.3
• 10.25.0
• 10.25.1
• 10.25.2
• 10.25.3
• 10.25.4
• 10.25.4-2
• 10.26.0
• 10.26.1
• 10.26.2
• 10.26.3
• 10.26.4
• 10.26.5
• 10.3.0
• 10.3.1
• 10.3.2
• 10.3.3
• 10.3.4
• 2-phase-commit-experiment
• 8
• 8-devtools-errors
• 8-perf-runs
• 8.5.1
• 8.5.2
• 8.5.3
• IE11-select
• JoviDeCroock-patch-1
• add-command-types
• add-missing-force-mangle
• add-owner-stack
• add-pkg-lock
• add-priority
• add-root-exports
• add-size-action
• add-test
• add-to-readable-stream
• allow-for-context-as-jsx
• apples-to-apples
• aria-attributes
• async-act
• attempt-string-extraction
• attribute-free-hydration
• automate-publishing
• avoid-cloning-reused-nodes
• babel-jsx
• benchmark-ci
• benchmarks-repo
• breaking-changes
• bug/fix-falsy-event-values
• bugfix-component-default-render
• bugfix-replacenode-differing-root
• bugfix/parking-suspense-parent-dom
• bugfix/support-adding-ref-to-memoed-components
• bugfix/support-touch-events-better-in-compat
• bugfix/suspense-fallback-mounted-twice
• bugfix/suspense-state-update
• bypass-props-during-hydration
• child-reordering-logging
• chore/__data
• chore/compat-built-script
• chore/mangleSuspensions
• chore/node-22
• chore/put-put-the-children-ref-list
• chore/remove-double-build-for-is
• chore/sync-mangle-files
• chore/ts-files
• chore/updateLinks
• chore/warnInvalidTable
• ci/fix-pr-reporter-forks
• ci/path-filter
• ci/reporter-filter
• ci/skip-benches-on-release
• classname-enumerable
• cleanup-hooks-unmount
• cleanup-test-dom
• coc
• code-of-conduct-github
• colin/0707/debug
• comapt-ts-tests
• command-event-handler-type
• comment-denoted-hydration
• commit-queues
• commonjs-plus-globals-default-export
• compat-classes
• compat-hydrate
• compat-modules
• compat-modules-2
• compat-modules-3
• compat-updates
• compat_render
• compat_types
• component-stack
• compose-catchError
• context-plumbing-top-bottom
• contributing-2
• contribution-guide
• controlled-mask
• coverage
• cross_browser2
• debug-component-thrashing
• debug-mode-performance
• debug-sort-attrs-for-ie11
• destroy-render
• devtools-pkg
• devtools-refactor
• devtools_tests_skip
• devtools_warning
• dialog-closedby
• diffchildren-index-tracking-2
• diffchildren-keys-check
• diffchildren-reduce-nextSibling-calls
• dont-forward-ref-for-classes
• draft-capture-golf
• drop-sinon
• edge_devtools
• editorconfig-json
• ensure-tested-and-all-exports-work
• enter-the-diff
• equalNode
• eslint-all-the-things
• eslintignore
• example-fix-controlled
• experimental-suspense-hydration
• falsy-replacement
• feat/8-compat-mode
• feat/add-state-suspend-test
• feat/add-unstable_batchedUpdates-to-compat
• feat/babel-transform-props
• feat/checkForNeedToEmit
• feat/cleanup-stale-refs
• feat/commit-queue
• feat/commitQueues
• feat/compat-treeshake
• feat/core-layout-effects
• feat/functionalErrorBoundaries
• feat/hooks-currentComponent-debug-check
• feat/hooks-in-core
• feat/hooks-in-core-andre
• feat/hooks-scheduling-golf
• feat/hydratingParam
• feat/improve-coverage
• feat/improve-double-toChildArray
• feat/improve-formatting
• feat/improve-lifecycle-ordering-test
• feat/improve-set-state-warnings
• feat/improve-tree-shakeability
• feat/inline-coerceToVNode
• feat/layout-component-queue
• feat/layout-render-callbacks
• feat/move-forwardRef-logic-to-core
• feat/non-keyed-children-tests
• feat/reduce-line-lengths
• feat/render-option
• feat/rework-debug-tests
• feat/simplify-compat
• feat/simplify-ternary-expressions
• feat/throw-error-for-hooks-outside-render
• feat/upgrade-test-babel
• feat/useProvider
• feat/vnode-render-callbacks
• feat/vnode-render-callbacks-2
• feature/parking-suspense
• fix-act-rerender
• fix-benchmark-debug
• fix-cbase
• fix-children-mapping
• fix-className
• fix-classname-normalization
• fix-ctx-issue
• fix-ecosystem-failure
• fix-hydrate-text-nodes
• fix-ie-element-tests
• fix-ie11-inputEvent
• fix-material-ui
• fix-memo
• fix-memory-leak
• fix-progressive-hydration
• fix-readme-compat-link
• fix-render-test
• fix-setstate-warning
• fix-static-content-hydration
• fix-stop-propagation
• fix-string-prototype-renders
• fix-subsequent-replace-nodes
• fix-test
• fix-text-always-rerendering
• fix-wsl
• fix-xvfb
• fix/_children-should-keep-their-type-as-array
• fix/add-scu-for-consumer
• fix/build
• fix/call-rendercallbacks-on-bail
• fix/cbComponentWillMount
• fix/circularRef
• fix/compat-internal-types
• fix/compat-test-utils
• fix/compatRangeInput
• fix/component-props
• fix/context
• fix/contextHijack
• fix/create-context-tests
• fix/debug
• fix/dont-use-internals
• fix/effect-error
• fix/enable-perf-tests
• fix/handle-the-fwd-ref-stale-rerender
• fix/hot-loader
• fix/hydration-mismatch-warning-clarity
• fix/ie11
• fix/ie11-tests
• fix/improve-code-coverage
• fix/improve-typings
• fix/layoutTiming
• fix/lazyForwardRef
• fix/mangle-hasScuFromHooks
• fix/master-sauce-tests
• fix/memoizedChildren
• fix/more-ts-tests
• fix/nested-setState-callbacks
• fix/nestedSetStateCb
• fix/noSiblings
• fix/null-placeholder-sibling-placement
• fix/offsets-and-focus
• fix/on-toggle-types
• fix/opacity0
• fix/portals
• fix/portals2.0
• fix/portalsInsertion
• fix/props
• fix/pureComponent
• fix/reduce-internals-in-tests
• fix/redux
• fix/ref_ordering
• fix/remove-unnecessary-context
• fix/remove-unused-code
• fix/rename-callback
• fix/repalceNodeUnmount
• fix/replace
• fix/replaceNodeWithComponents
• fix/restoreDebounceRendering
• fix/reusage
• fix/skip-setter-for-href
• fix/stale_closure_error_boundary
• fix/suspense-broken-cases
• fix/suspense-fallback
• fix/suspense-null-fallback
• fix/suspense-scu
• fix/suspensions-rename-mangle
• fix/test-build-output
• fix/test-minified-output
• fix/transitions
• fix/types
• fix/uncontrolledInputs
• fix/unmount
• fix/useImpHandle
• fix/useImperativeHandle-changing-ref
• fix/useImperativeHandleCrash
• fix/useImperativeHandleWithFunc
• fix/useStateArgument
• fix_4631
• fix_focus_loss
• fix_form_ie11
• fix_ie_test
• fix_state_cwM
• fix_styles_clearing
• forEachChild
• force-update-reset
• forceupdate-diffChildren2
• forceupdate-diffChildren3
• forceupdate-queue-participation
• forward-ref-by-default-2
• forwarding-components-reacttag
• fragment_reordering3
• golf-dom
• golf-minor
• golfing
• golfing-2
• handle-flush-hook-changes
• hooks-golf
• hooks-in-core
• http-to-https
• ie-contains-fix
• ie-failing-test
• ie-polygon
• ie11
• iframe-reload
• imperative-tests
• implement-umd-proposition
• improve-coverage
• improve-sibling-code
• improve-test-dom-helpers
• improve-var-names
• improvement/simplify-suspense-catch-error
• improvement/suspense-bugs
• inline-diff-props
• inline-diff-props-stats
• intrinsic
• issue-templates-2
• layoutEffect
• lifecycle-files
• main
• make-debug-browser-ready
• making-things-smaller
• mangle-has-scu
• master
• migrate-to-jasmine
• more-readme
• move-to-gh-actions
• multi_select
• nested-children
• new_devtools
• node-submodule-exports
• null-constant
• old-unmount
• onbeforetoggle-types
• one-diff-to-rule-them-all
• one-diff-to-rule-them-all-2
• optimization-avoid-known-setproperty-cases
• optimization-setproperty-stack-depth
• optimizations-1
• optimize-bundle-size
• optimize-bundles
• optimize-child-diff
• optimize-createelement
• options-enhance
• options-vnode-on-rerender
• package-metadata
• parent-pointer
• patch-1
• perf
• perf-fn-prototype
• pkg-funding
• portalsFix
• portals_destroyer
• post-commit-queue
• potential-fix-memory-leak
• potential-fix-remove-old-children
• prateekbh/suspense-hydration
• preact-devtools
• prettier-2
• prevent-demo-postinstall
• privatize-options
• privatize-unmount
• propogation-stopped
• prrateekbh/temp
• prune-portals
• prune-suspense
• queue-microtask
• re-enable_coveralls
• reduce-excessDomChildren-searches
• reduce-raf-timeout-35ms
• redux_bug2
• redux_demo
• ref-hydration-flag
• ref-unmount-imperative-handle
• refactor-process
• refactor/aria-role-subset
• refactor/default-element-targets
• refactor/disallow-generic-aria-role
• refactor/event-inference
• refactor/golf-pointer-capture
• refactor/golf-strict-eq
• refactor/pkg-exports
• refactor/useRef
• refs/tags/10.10.0
• refs/tags/10.10.1
• refs/tags/10.10.2
• refs/tags/10.10.3
• refs/tags/10.10.4
• refs/tags/10.10.5
• refs/tags/10.10.6
• refs/tags/10.11.0
• refs/tags/10.11.1
• refs/tags/10.11.2
• refs/tags/10.11.3
• refs/tags/10.12.0
• refs/tags/10.12.1
• refs/tags/10.13.0
• refs/tags/10.13.1
• refs/tags/10.13.2
• refs/tags/10.14.0
• refs/tags/10.6.4-test
• refs/tags/10.6.5
• refs/tags/10.6.6
• refs/tags/10.7.1
• refs/tags/10.7.2
• refs/tags/10.7.3
• refs/tags/10.8.0
• refs/tags/10.8.1
• refs/tags/10.8.2
• refs/tags/10.9.0
• release-10.0.0
• release-10.0.0-rc.2
• release-10.0.0-rc.3
• release-10.0.3
• release-10.0.5
• release-10.1.0
• release-10.1.1
• release-10.2.0
• release-10.2.1
• release-10.3.0
• release-10.3.1
• release-10.3.2
• release-10.3.3
• release-guide
• release_10.0.0-beta.2
• release_10.0.1
• release_10.0.2
• remove-automatic-px
• remove-compat-vnode-hook
• remove-contains
• remove-defaultprops
• remove-donate-banner
• remove-effect-warnings
• remove-missing-null
• remove-postinstall
• remove-static-dom-bail
• remove-toChildArray
• remove-unused-deps
• rename-lastDomChildSibling
• render-to-string-dep
• replaceNode
• reporting-bugs
• restructure
• restructure-devtools
• revert-1276
• revert-hole-unmount
• revert-memory-stuff
• revert-vitest
• revert/#4724
• revert/force-update-edgecase
• revert/refactor-all-html-attributes
• review-feedback-v11
• rschristian-patch-1
• saucelabs_safari
• save-bytes
• scu-fix-2
• select-polyfill
• select-polyfill-alt
• setstate-warn
• shared-internals
• shift-to-pop
• sinon-es
• sinon-es2
• size-impact-deprecated-comp-lifecycles
• size-null
• skip-append-for-element-text-child
• small-deps
• some-reverts
• split-mount-patch
• split-vnode-types
• strict-equality
• string_style
• support-catch-derivation
• support-react-19
• support-template
• suspense-lazy-nondefault
• suspense-list
• suspense-update
• switch-to-vitest
• test/drop-unstable-batched-test
• test/node-stream-warning
• tests/portal
• this-jsx
• try-optimizations
• two-phase-diffChildren-2
• two-phase-diffChildren-2-deopts
• types/all-html-attributes
• types/compat-aria-attributes
• types/compat-event-handler
• types/compat-forward-ref-render-function
• types/compat-server-scheduler
• types/html-props
• types/media-element
• types/remove-all-html-attributes
• types/remove-defaultprops
• types/use-ref-initial
• typings
• unpkg-aliases
• unsafe-descr
• update-fragment-tests
• update-readme
• use-npm-ci
• use-obj-assign
• v11
• v11-2
• v11-benchmark-base
• v11-forward-ref-by-default
• v8-devtools-attempt-6
• valid_elem
• vitest-sinon-browser-components
• vitest-sinon-browser-context
• vitest-sinon-browser-createcontext
• vitest-sinon-browser-lifecycles
• vitest-sinon-browser-refs-events
• vitest-sinon-browser-round3
• vitest-sinon-compat
• vitest-sinon-debug
• vitest-sinon-hooks
• vitest-v8
• vnode-original-tracking
• vnode-prop-explorations
• zero-mutation-text-hydration

Build # 5611

Build Type

Pull #1984

travis-ci

Committed by web-flow

Commit Message

sCU shouldn't block forceUpdate from child

The way MobX works is that every observed component returns false
from shouldComponentUpdate unless props have changed. They than
trigger the child renders themselves via direct forceUpdate calls.

Our issue was that we only set the force flag sort-of globally
during a render and would ignore any children that have been
enqueued via forceUpdate in the same render cycle. With these
changes we ensure that the force flag is always the one from
the current component.

Pull Request Pull Request #1984: Always pull force flag from component

Run Details

826 of 851 branches covered (97.06%)

6 of 6 new or added lines in 3 files covered. (100.0%)

856 of 858 relevant lines covered (99.77%)

775.07 hits per line