preactjs / preact / 5611

100%

master: 100%

Pull #1984

travis-ci

sCU shouldn't block forceUpdate from child

The way MobX works is that every observed component returns false
from shouldComponentUpdate unless props have changed. They than
trigger the child renders themselves via direct forceUpdate calls.

Our issue was that we only set the force flag sort-of globally
during a render and would ignore any children that have been
enqueued via forceUpdate in the same render cycle. With these
changes we ensure that the force flag is always the one from
the current component.

826 of 851 branches covered (97.06%)

6 of 6 new or added lines in 3 files covered. (100.0%)

856 of 858 relevant lines covered (99.77%)

775.07 hits per line