playwright-community / playwright-go

79%

main: 79%

LAST BUILD ON BRANCH fix/set-input-files-default-timeout

branch: fix/set-input-files-default-timeout

CHANGE BRANCH

x

Reset

• fix/set-input-files-default-timeout
• add-logger-override-support
• add-only-install-shell-option
• align-with-upstream-client
• chore/gitignore-claude
• chore/update-github-actions
• ci-fail
• ci/concurrency-cancel-prs-only
• dataRace
• docs-cli-ver
• docs/fix-readme-and-contributing
• expose-redirected-navigation-request
• feat/assemble-driver-from-npm-and-nodejs
• feat/flakiness-io-reporter
• fix-sizes-panic
• fix-tests
• fix/579-expect-download-mobile-test
• fix/connection-deadlocks
• fix/dispatcher-event-handler-deadlock
• fix/evaluate-handle-element-panic
• fix/event-emitter-lock-across-handlers
• fix/handle-parsing-float
• fix/locator-evaluate-attached-state
• fix/remote-upload-flake
• fix/request-header-shape
• fix/response-null-structured-results
• fix/test_worker
• fix/waiter_deadlock
• fix/webkit-folder-upload-timeout-180s
• main
• misuse-matrix
• mxschmitt/budapest
• mxschmitt/columbus
• mxschmitt/dallas-v2
• mxschmitt/kyiv-v4
• mxschmitt/macau-v1
• mxschmitt/victoria-v1
• patch-1
• patch-2
• patch-nilerror
• pr/event-handler-deadlock
• pr/jsonpipe-deadlock
• roll-v1.49.1
• roll-v1.50
• roll-v1.51
• roll-v1.52
• roll/v1.59.1
• roll/v1.60.0
• roll/v1.61.1
• tidy-1.57
• update-dependency

Build # 28135373441

Build Type

Pull #595

github

Committed by mxschmitt

Commit Message

test: fix flaky TestPageCloseRace deadlock

TestPageCloseRace intermittently hung for the full 15m test timeout on CI (reproducible locally ~1 in 8 runs when run alongside TestBrowserContextCloseRace).

Protocol tracing showed page.Close() sends "close" but the Chromium driver never replies when Close() races a navigation that commits at the same instant — a driver-level deadlock outside the binding's control. In the passing case Close() aborts the in-flight navigation (net::ERR_ABORTED) and returns immediately.

Abort the request instead of fulfilling it so the navigation never commits. This still exercises the close-vs-route-handler data race the test guards against (issue #566): the handler goroutine runs concurrently with Close() and reads pageImpl.closeWasCalled, still caught by -race. Verified 30/30 passing with -race after the change.

Pull Request Pull Request #595: fix: respect default timeout in SetInputFiles; fix flaky TestPageCloseRace

Coverage Stats

14 of 16 new or added lines in 2 files covered. (87.5%)

7927 of 10098 relevant lines covered (78.5%)

6562.06 hits per line