playwright-community / playwright-go

80%

main: 79%

LAST BUILD ON BRANCH dataRace

branch: dataRace

CHANGE BRANCH

x

Reset

• dataRace
• add-logger-override-support
• add-only-install-shell-option
• align-with-upstream-client
• chore/gitignore-claude
• chore/update-github-actions
• ci-fail
• ci/concurrency-cancel-prs-only
• docs-cli-ver
• docs/fix-readme-and-contributing
• expose-redirected-navigation-request
• feat/assemble-driver-from-npm-and-nodejs
• feat/flakiness-io-reporter
• fix-sizes-panic
• fix-tests
• fix/579-expect-download-mobile-test
• fix/connection-deadlocks
• fix/dispatcher-event-handler-deadlock
• fix/evaluate-handle-element-panic
• fix/event-emitter-lock-across-handlers
• fix/handle-parsing-float
• fix/locator-evaluate-attached-state
• fix/remote-upload-flake
• fix/request-header-shape
• fix/response-null-structured-results
• fix/set-input-files-default-timeout
• fix/test_worker
• fix/waiter_deadlock
• fix/webkit-folder-upload-timeout-180s
• main
• misuse-matrix
• mxschmitt/budapest
• mxschmitt/columbus
• mxschmitt/dallas-v2
• mxschmitt/kyiv-v4
• mxschmitt/macau-v1
• mxschmitt/victoria-v1
• patch-1
• patch-2
• patch-nilerror
• pr/event-handler-deadlock
• pr/jsonpipe-deadlock
• roll-v1.49.1
• roll-v1.50
• roll-v1.51
• roll-v1.52
• roll/v1.59.1
• roll/v1.60.0
• roll/v1.61.1
• tidy-1.57
• update-dependency

Build # 28125534279

Build Type

Pull #567

github

Committed by mxschmitt

Commit Message

fix: also make pageImpl.closeWasCalled atomic

PR #567 made browserContextImpl.closeWasCalled atomic but left the
identical race on pageImpl.closeWasCalled: Page.Close() writes it while
the page's route-handler goroutine reads it in onRoute(). Convert it to
atomic.Bool too and add TestPageCloseRace covering that path.

Pull Request Pull Request #567: Fix data race between routing and closing context

Coverage Stats

4 of 4 new or added lines in 2 files covered. (100.0%)

763 existing lines in 19 files now uncovered.

7679 of 9557 relevant lines covered (80.35%)

4980.13 hits per line