• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pantsbuild / pants / 6375
74%
main: 93%

Build:
Build:
LAST BUILD BRANCH: fix/python-build-standalone-provider-in-docker-env
DEFAULT BRANCH: main
Ran 24 Aug 2015 01:09AM UTC
Jobs 10
Files 352
Run time 8min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
6375

push

travis-ci

stuhood
Add a just-in-time check of the artifact cache to the isolated compile strategy

Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thousands potentially), and then begin compiling them, without ever checking the cache again.

In the future, pushing the invalidation check down into the `work` function that runs the compilation could be the cleanest solution. But currently I would be concerned by threadsafety in the build invalidator and elsewhere. Instead, this patch adds a double-check of the cache inside the work function.

- Add a double check of the cache to the isolated strategy immediately before beginning to compile.

Testing Done:
https://github.com/pantsbuild/pants/pull/2052

Reviewed at https://rbcommons.com/s/twitter/r/2690/

21 of 21 new or added lines in 2 files covered. (100.0%)

15763 of 21339 relevant lines covered (73.87%)

1.39 hits per line

Uncovered Changes

Lines Coverage ∆ File
18
100.0
src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile_isolated_strategy.py
1
100.0
src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py

Coverage Regressions

Lines Coverage ∆ File
1
100.0
src/python/pants/backend/jvm/tasks/jvm_compile/jvm_compile.py
Jobs
ID Job ID Ran Files Coverage
1 6375.1 (CI_FLAGS="-cjlpn 'Various pants self checks'") 24 Aug 2015 01:10AM UTC 0
Travis Job 6375.1
2 6375.2 (CI_FLAGS="-fkmsrcn -u 0/2 'Unit tests for pants and pants-plugins - shard 1'") 24 Aug 2015 01:11AM UTC 0
69.8
Travis Job 6375.2
3 6375.3 (CI_FLAGS="-fkmsrcn -u 1/2 'Unit tests for pants and pants-plugins - shard 2'") 24 Aug 2015 01:10AM UTC 0
69.37
Travis Job 6375.3
4 6375.4 (CI_FLAGS="-fkmsrcjlp 'Python contrib tests'") 24 Aug 2015 01:09AM UTC 0
Travis Job 6375.4
5 6375.5 (CI_FLAGS="-fkmsrjlpn -i 0/6 'Python integration tests for pants - shard 1'") 24 Aug 2015 01:10AM UTC 0
Travis Job 6375.5
6 6375.6 (CI_FLAGS="-fkmsrjlpn -i 1/6 'Python integration tests for pants - shard 2'") 24 Aug 2015 01:15AM UTC 0
Travis Job 6375.6
7 6375.7 (CI_FLAGS="-fkmsrjlpn -i 2/6 'Python integration tests for pants - shard 3'") 24 Aug 2015 01:18AM UTC 0
Travis Job 6375.7
8 6375.8 (CI_FLAGS="-fkmsrjlpn -i 3/6 'Python integration tests for pants - shard 4'") 24 Aug 2015 01:17AM UTC 0
Travis Job 6375.8
9 6375.9 (CI_FLAGS="-fkmsrjlpn -i 4/6 'Python integration tests for pants - shard 5'") 24 Aug 2015 01:16AM UTC 0
Travis Job 6375.9
10 6375.10 (CI_FLAGS="-fkmsrjlpn -i 5/6 'Python integration tests for pants - shard 6'") 24 Aug 2015 01:16AM UTC 0
Travis Job 6375.10
Source Files on build 6375
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #6375
  • d6a7ad64 on github
  • Prev Build on twitter/pants-1.2.6 (#6249)
  • Next Build on twitter/pants-1.2.6 (#6386)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc