pantsbuild / pants / 6375

74%

main: 93%

push

travis-ci

Add a just-in-time check of the artifact cache to the isolated compile strategy

Now that we have a single large chunk arriving in ZincCompile, the `self.invalidated` block for compilation will do a single upfront check for all cache entries (thousands potentially), and then begin compiling them, without ever checking the cache again.

In the future, pushing the invalidation check down into the `work` function that runs the compilation could be the cleanest solution. But currently I would be concerned by threadsafety in the build invalidator and elsewhere. Instead, this patch adds a double-check of the cache inside the work function.

- Add a double check of the cache to the isolated strategy immediately before beginning to compile.

Testing Done:
https://github.com/pantsbuild/pants/pull/2052

Reviewed at https://rbcommons.com/s/twitter/r/2690/

21 of 21 new or added lines in 2 files covered. (100.0%)

15763 of 21339 relevant lines covered (73.87%)

1.39 hits per line