openconfig / containerz

64%

master: 64%

LAST BUILD ON BRANCH handle-move-plugin

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• 20260204-mdev-close-writer
• atomic-plugin-write
• client_push_image_closesend
• create-plugins-location
• custom-plugin-support
• dependabot/go_modules/golang.org/x/net-0.38.0
• dependabot/go_modules/google.golang.org/grpc-1.79.3
• device_support
• errors
• fix-cmd-container-update
• fix-lint
• force-deadline
• gnoi-v0.8.0
• gnoigo
• handle-move-plugin
• label-as-intended
• label-location
• linterfix
• log-list-all
• master
• only-stop-container
• plugin-list-fix
• plugin-tmp-name
• renovate/deps
• server-options
• start-container-shell
• start-without-autoremove
• stop-response
• tests
• tmp-file-removal
• update-async-no-ctx

Build # 23849992600

Build Type

Pull #71

github

Committed by brianneville

Commit Message

server: avoid logging an error when deploying plugins

when a plugin is deployed, we were moving and then deleting
the temporary file.
However we are unconditionally calling chunkWriter.Cleanup
when exiting from handleImageTransfer, which means that for plugins
we would be always logging an error.
In this change, we change the Cleanup function so that it can be
called multiple times, but will only run once, and will always
return the error from the first invocation.

Pull Request Pull Request #71: server: avoid logging an error when deploying plugins

Run Details

10 of 10 new or added lines in 2 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

1726 of 2709 relevant lines covered (63.71%)

0.72 hits per line