openconfig / containerz

63%

master: 64%

LAST BUILD ON BRANCH start-without-autoremove

branch: start-without-autoremove

CHANGE BRANCH

x

Reset

Sync Branches

• start-without-autoremove
• create-plugins-location
• custom-plugin-support
• dependabot/go_modules/golang.org/x/net-0.38.0
• device_support
• errors
• fix-cmd-container-update
• fix-lint
• force-deadline
• gnoigo
• linterfix
• log-list-all
• master
• only-stop-container
• plugin-list-fix
• server-options
• start-container-shell
• stop-response
• tests
• update-async-no-ctx

Build # 14034803129

Build Type

Pull #29

github

Committed by brianneville

Commit Message

container/docker: start containers without AutoRemove

If the AutoRemove field is set to true, then:
1. StopContainer RPC calls (including the call to
StopContainer made as part of the UpdateContainer
RPC) will fail as the line
https://github.com/openconfig/containerz/blob/012a091c1/containers/docker/container_stop.go#L51
will send a stop signal, as well as triggering
the container to be removed automatically.
This will cause the subsequent
m.client.ContainerRemove call to fail with an error
as the container removal is already in process.

2. Containers cannot be started with a restart policy
(docker will fail to start the container if it has a
non-nil restart policy while AutoRemove is true.

So this field can be left as false, and the removal
is ensured by the StopContainer RPC call anyway.

Pull Request Pull Request #29: container/docker: start containers without AutoRemove

Run Details

1607 of 2540 relevant lines covered (63.27%)

0.71 hits per line