nvidia-holoscan / holoscan-cli
79%
main: 79%

Repo Added 05 Dec 2024 01:17AM UTC

Committed 14 Aug 2026 10:22AM UTC coverage: 78.535% (-0.06%) from 78.599%

Committed by

Commit Message

fix: resolve pre-commit with the child-process PATH

`handle_lint` prepends `~/.local/bin` to the PATH it hands to the subprocess
when the CLI is not running inside a virtualenv, but `_pre_commit_command`
called `shutil.which` without that PATH, so resolution and execution consulted
different search paths.

A pipx- or `--user`-installed pre-commit lives only in that directory and is
not importable by the CLI's interpreter. It was therefore reported as missing,
triggering an unnecessary reinstall, or a fatal pip error in an environment
that has no pip -- while a perfectly usable executable was already on the PATH
the run would use. `--dryrun` also printed `python -m pre_commit`, a module
that does not exist there.

Thread the child-process PATH through `_pre_commit_command` at both the
resolution and post-install checks, and at the hook-prefetch call in
`_install_lint_deps`.

Reported by CodeRabbit on PR #221.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Coverage Stats

23 of 36 new or added lines in 5 files covered. (63.89%)

1 existing line in 1 file now uncovered.

3260 of 4151 relevant lines covered (78.54%)

0.79 hits per line

4151 RELEVANT LINES 3260 COVERED LINES

0.79 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
31792063975	agent/fix-source-project-portability	fix: resolve pre-commit with the child-process PATH `handle_lint` prepends `~/.local/bin` to the PATH it hands to the subprocess when the CLI is not running inside a virtualenv, but `_pre_commit_command` called `shutil.which` without that PATH, s...	Pull #221	14 Aug 2026 10:24AM UTC	wyli	github	78.54
31790952217	agent/fix-source-project-portability	fix: sync bundled template requirements with the create extra `setup_scripts/requirements.template.txt` ships in the wheel and is pip-installed by `setup_scripts/template.sh`, so it is a second declaration of the dependency set that `[project.opt...	Pull #221	14 Aug 2026 10:08AM UTC	wyli	github	78.54
31699620650	agent/fix-source-project-portability	fix: align module name resolution Use one normalization rule for metadata discovery and module packaging, and cover the lint environment and requirements precedence review cases without adding standalone test functions. Co-authored-by: Codex <no...	Pull #221	13 Aug 2026 12:21PM UTC	wyli	github	78.68
31698415380	agent/fix-source-project-portability	test: consolidate source-project regressions Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Wenqi Li <wenqil@nvidia.com>	Pull #221	13 Aug 2026 12:06PM UTC	wyli	github	78.65
31697928592	agent/fix-source-project-portability	fix: preserve source-project context Forward local SDK roots through test containers, preserve declared Module identity across checkout and mount paths, and make lint hooks use the selected CLI Python and root lint requirements. Co-authored-by: ...	Pull #221	13 Aug 2026 11:59AM UTC	wyli	github	78.65

nvidia-holoscan / holoscan-cli
79%
main: 79%

nvidia-holoscan / holoscan-cli 79% main: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on agent/fix-source-project-portability

Recent builds

nvidia-holoscan / holoscan-cli
79%
main: 79%

README BADGES
x

CHANGE BRANCH
x