nvidia-holoscan / holoscan-cli / 31790952217

79%

main: 79%

Build Type

Pull #221

github

Committed by wyli

Commit Message

fix: sync bundled template requirements with the create extra

`setup_scripts/requirements.template.txt` ships in the wheel and is
pip-installed by `setup_scripts/template.sh`, so it is a second declaration of
the dependency set that `[project.optional-dependencies].create` already owns.
The two had diverged: the bundled file asked for jsonschema>=4.26.0 and
referencing>=0.36.2, while the extra asks for jsonschema>=4.18,<5.0 and
referencing>=0.30.

The divergence was in the dangerous direction. Only the extra carries the
jsonschema<5.0 cap, and that cap exists because metadata_validator.py uses
Draft202012Validator(..., registry=...). `holoscan setup template` could
therefore install a jsonschema release that `holoscan create` is documented not
to support, while `pip install 'holoscan-cli[create]'` could not.

The extra is authoritative because the CLI imports these packages, so a plain
pip install has to be sufficient. Point the bundled file at the same
constraints and add a package-data test that fails when they disagree; the
validator only needs Draft202012Validator and the core referencing Registry
APIs, so no higher floor is warranted.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Pull Request Pull Request #221: fix: preserve source-project context

Coverage Stats

23 of 36 new or added lines in 5 files covered. (63.89%)

1 existing line in 1 file now uncovered.

3260 of 4151 relevant lines covered (78.54%)

0.79 hits per line