nvidia-holoscan / holoscan-cli / 31792063975

79%

main: 79%

Build Type

Pull #221

github

Committed by wyli

Commit Message

fix: resolve pre-commit with the child-process PATH

`handle_lint` prepends `~/.local/bin` to the PATH it hands to the subprocess
when the CLI is not running inside a virtualenv, but `_pre_commit_command`
called `shutil.which` without that PATH, so resolution and execution consulted
different search paths.

A pipx- or `--user`-installed pre-commit lives only in that directory and is
not importable by the CLI's interpreter. It was therefore reported as missing,
triggering an unnecessary reinstall, or a fatal pip error in an environment
that has no pip -- while a perfectly usable executable was already on the PATH
the run would use. `--dryrun` also printed `python -m pre_commit`, a module
that does not exist there.

Thread the child-process PATH through `_pre_commit_command` at both the
resolution and post-install checks, and at the hook-prefetch call in
`_install_lint_deps`.

Reported by CodeRabbit on PR #221.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Pull Request Pull Request #221: fix: preserve source-project context

Coverage Stats

23 of 36 new or added lines in 5 files covered. (63.89%)

1 existing line in 1 file now uncovered.

3260 of 4151 relevant lines covered (78.54%)

0.79 hits per line