npm / cli

97%

latest: 97%

LAST BUILD ON BRANCH isaacs/locale-compare-en

branch: isaacs/locale-compare-en

CHANGE BRANCH

x

Reset

• isaacs/locale-compare-en
• feature/test-checkout-v2
• latest
• chore/reverse-docs-links-fix
• chore/npm-log
• assapir/redact-password
• fix/logs-url
• nlf/add-token-tests
• isaacs/fix-publish-tag
• release/7.0.0
• release/v7.0.0
• nlf/more-random-tests
• release/v7.0.0-rc.3
• nlf/npx-run-existing-bins
• nlf/restore-user-agent-env
• nlf/fix-npx-for-non-interactive-use
• release/v7.0.0-rc.4
• nlf/pass-publishConfig
• darcyclarke/fix-broken-help-docs-ref
• release/v7.0.0-staging
• release/v7.0.0-staging-isaacs
• v6
• isaacs/audit-handle-failed-endpoint
• release/v7.0.1
• release/v7.0.2
• release/v7.0.3
• isaacs/cmd-env-fix
• release/v7.0.4
• release/v7.0.5
• nlf/skip-prompt-in-ci
• isaacs/pack-do-not-show-bundled-files
• isaacs/better-view-error-on-invalid-package-json
• release/v7.0.6
• isaacs/publishConfig-support-all-keys
• isaacs/bash-to-sh
• nlf/fix-make-release
• isaacs/publish-non-directories
• nlf/delete-contents-not-dir
• release/v7.0.7
• release/v7.0.8
• nlf/update-install-script
• nlf/cache-tests
• release/v7.0.9
• isaacs/default-command
• release/v7.0.10
• isaacs/process-title
• isaacs/json-errors-to-stderr
• isaacs/explain-dep-name-missing-bugfix
• darcyclarke/pass-flatoptions-in-ci
• release/v7.0.11
• nlf/fix-empty-scripts
• isaacs/builtin-config-preservation
• release/v7.0.12
• isaacs/better-script-escaping
• release-6.14.9
• release/v7.0.13
• release/v7.0.14
• release/v7.0.15
• release/v7.1.0
• nlf/deprecate-tests
• nlf/search-opts
• release/v7.1.1
• nlf/completion-tests
• isaacs/ci-scripts
• nlf/doctor-tests
• isaacs/docs-2020-12-10
• isaacs/set-node-env-production
• release/v7.1.2
• darcyclarke/remove-extraneous-tough-cookie
• isaacs/ini-2
• nlf/fix-rebuild
• nlf/edit-tests
• nlf/help-search-tests
• nlf/help-tests
• nlf/hook-tests
• nlf/org-tests
• nlf/set-tests
• nlf/remove-unused-modules
• release/v7.2.0
• isaacs/faster-make-publish-no-docs-clean
• nlf/fix-doctor-tests
• isaacs/publish-fail-when-no-registry-no-login
• isaacs/config-set-multi
• release-v6.14.10
• release/7.2.1
• nlf/remove-metrics
• release/v7.3.0
• darcyclarke/update-reademe
• isaacs/foreground-scripts
• isaacs/remove-process-umask
• nlf/fix-script-args
• gar/ci_ignore_scripts
• release/v7.4.0
• release-v6.14.11
• gar/docs_start
• gar/docs_stop
• gar/docs_test
• gar/docs_prefix
• gar/docs_uninstall
• gar/docs_unpublish
• isaacs/docs-lockfile
• gar/docs_token
• nlf/stop-breaking-linked-packages
• gar/docs_search
• gar/docs_shrinkwrap
• release/v7.4.1
• release/v7.4.2
• darcyclarke-patch-npm-docs
• ruyadorno/npm-diff
• release/v7.4.3
• gar/test-help-coverage
• gar/init-cache
• darcyclarke/update-docs
• gar/docs-npm
• release/v7.5.0
• docs-npm-team
• nlf/remove-require-from-string
• isaacs/doc-config-force-peer-deps-override
• isaacs/ci-rm-timer
• isaacs/broader-istanbul-ignore-in-help-search
• nlf/fix-proxy-outdated
• release/7.5.1
• gar/init-latest
• release/v7.5.2
• nlf/remove-spawn-util
• gar/alt-registry-auth
• nlf/curl-fix
• release/v7.5.3
• isaacs/do-not-clobber-env-run-script
• gar/preinstall
• release/v7.5.4
• darcyclarke-update-readme-with-branding-ref
• gar/docs-lifecycle
• gar/fix-preinstall
• nlf/no-global-dedupe
• gar/publish-tests
• nlf/restore-tag-prefix-on-version
• gar/silent-run-script
• release/v7.5.5
• isaacs/release-v7.5.5-arborist-update
• isaacs/quieter-exec
• isaacs/hide-easter-egg-better
• gar/lifecycle-cmd-refactor
• release/7.5.6
• gar/completion-refactor
• christoflemke/update-publish-docs
• release/v7.5.6
• release/v7.6.0
• isaacs/ls-test-update-hidden-lock-file-mtime
• isaacs/fix-windows-shell-bins
• gar/npm-state
• gar/npm-output
• gar/searchopts
• baj-/update-unpublish-docs
• gar/usage
• release/v7.6.1
• gar/promisify
• gar/flatoptions
• release/v7.6.2
• nlf/dont-publish-more-files
• release/v7.6.3
• gar/help-search
• isaacs/config-refactor
• release-next
• isaacs/restore-npm-command-flat-option
• isaacs/config-refactor-phase-2
• gar/suggestions-cleanup
• gar/usage-from-config
• gar/unknown-action-item
• release/v7.7.0
• gar/audit-level-info
• gar/install-audit-level
• gar/install-save-exact
• release/v7.7.1
• isaacs/2936
• release/v7.7.2
• gar/install-progress-bar
• nlf/config-workspaces
• gar/_auth
• release/v7.7.3
• gar/changelog-manual-hiccup
• gar/explicit-production
• release/v7.7.4
• isaacs/set-npm-command-to-canonical-command
• gar/user-agent-config
• gar/save-exact-prefix
• release/v6.14.12
• release/v7.7.5
• gar/docs-workspaces
• release/v7.7.6
• nlf/workspaces-set-script
• gar/view-workspaces
• gar/workspaces-docs
• isaacs/add-env-export-false-flag-for-config-defs
• isaacs/eresolve-report-on-edge-if-node-missing
• isaacs/correct-usage-multiples
• release/v7.8.0
• nlf/workspaces-dist-tag
• gar/pack-workspaces
• gar/workspaces-version
• release/v7.9.0
• darcyclarke-patch-1
• release/v6.14.13
• gar/tap15
• nlf/no-error-for-extraneous-deps
• release/v7.10.0
• gar/view-ws-docs
• gar/pack-name-version
• gar/test-err-consistency
• debug-npm-registry-fetch-logout-test
• release/v7.11.0
• isaacs/remove-always-auth-config-def
• isaacs/ls-ignore-missing-optionals
• release/v7.11.2
• nlf/add-workspaces-to-user-agent
• gar/exec-test-fix
• release/v7.12.0
• gar/test-time-fix
• gar/view-git-fix
• gar/mock-npm-config
• gar/publish-workspaces
• release/v7.12.1
• isaacs/reify-workspaces
• release/v7.13.0
• isaacs/auto-generate-cmd-config-docs-from-params
• gar/test-usage-snapshot
• gar/unpublish-workspaces
• isaacs/less-noisy-links-in-ls
• release/v7.14.0
• isaacs/audit-level-reify-exit-code
• isaacs/link-workspace
• isaacs/prefix-over-local-prefix
• gar/node-gyp-8
• release/v7.16.0
• release/v7.15.0
• gar/exec-output
• gar/diff-workspaces
• release/v7.15.1
• gar/diff-workspaces-refactor
• isaacs/no-notifier-for-installing-npm-at-latest
• isaacs/parallelize-update-notifier
• gar/loglevel-background
• isaacs/trim-node-modules
• nlf/no-writefile-in-pack-tests
• isaacs/use-files-list-in-package.json
• gar/linting
• gar/login-scope
• gar/npm-references
• gar/outdated-in-range
• release/v7.17.0
• gar/exit-handler
• gar/workspaces-consolidate-logic
• gar/config-link
• gar/pack-destination
• support-virtual-listing
• gar/diff-tests
• gar/exec-cache
• lk/test-gpg
• release/v7.18.0
• gar/rebuild-docs
• release/v7.18.1
• feature/improve-workspaces-docs
• gar/npm-load
• gar/real-npm-mock
• gar/config-snapshot
• isaacs/ls-invalid-helpful-info
• gar/more-real-tests
• isaacs-gar/coverage-map-update
• release/v7.19.0
• gar/no-exit-handler
• nlf/config-location
• gar/stale-timings
• ruyadorno/npm-pkg
• gar/exit-handler-mark-two
• gar/view-test-cleansnap
• gar/undeprecate
• gar/docs-package-config
• gar/hooks-docs
• gar/bin-install-docs
• release/v7.19.1
• gar/npm-update-docs
• gar/publish-ignore-scripts
• fetch-patch
• gar/ci-audit-param
• nlf/explain-socket-timeout
• gar/update-notifier-color
• gar/config-noproxy
• update-policy-urls-v7
• gar/case-sensitive-node-modules
• PR-3542
• release/v7.20.0
• gar/always-exit-check
• gar/npm-pkg-typo
• gar/npm-color
• gar/pretty-bytes
• release/v7.20.1
• release/v6.14.14
• release/v7.20.2
• gar/workspace-dot
• isaacs/update-arborist-2.8.0
• gar/fix-case-sensitive-snafu
• release/v7.20.3
• isaacs/workspace-root
• release/v7.20.4
• release/v7.20.5
• gar/fastest-levenshtein
• release/v7.20.6
• gar/publish-docs-fix
• isaacs/auto-generated-docs-comment
• gar/clean-argv
• gar/parse-error-path
• isaacs/more-docs-human-error-prevention
• release/v7.21.0
• fritzy/scriptdocs-uninstall
• release/v6.14.15
• nlf/fix-some-flat-options
• gar/config-tests
• release/v7.21.1
• release/v7.22.0
• darcyclarke/update-contribution-guidelines
• gar/npm-engines-check
• gar/creds-in-error
• release/v7.23.0
• gar/dym-no-pkg
• gar/install-no-rm
• gar/user-agent-ci
• gar/git-error-cleanup
• gar/node-12
• isaacs/node-12
• lk/npmlog
• release/v7.24.0
• fritzy/include-workspace-root
• release/v7.24.1
• gar/windows-open-url
• ethomson/docs
• isaacs/string-locale-compare
• lk/cli-columns
• deps/arborist-2-10-0
• isaacs/workspace-dot
• release/v7.25.0
• lk/revert-workspace-root
• release/v7.24.2
• fritzy/workspace-root
• unpublished-by-undefined
• gar/publish-test-fix
• MylesBorins-patch-1
• gar/security-md
• release/v8.0.0
• darcyclarke-patch-2
• darcyclarke-patch-3
• gar/index-js
• isaacs/lockfile-version-config
• deps/pacote-12-0-1
• 6.4
• olefriis-mistake-6.4
• lk/3881
• deps/ci-detect-1-4-0
• nlf/arborist-update
• nlf/update-ci-detect
• nlf/pacote-update
• +nlf/arborist-update
• release/v8.1.0
• deps/node-gyp-8-3-0
• lk/update-arborist
• release/v8.1.1
• gar/404-log-http
• voxpelli-patch-1
• lk/config-lockfile-version
• lk/arborist-4.0.3
• gar/refactor-commands
• release/v8.1.2
• nlf/update-ci-workflow
• gar/latest-npm-issue-template
• lk/3962-shrinkwrap
• lk/shrinkwrap-on-command-refactor
• lk/lint-test-on-command-refactor
• v7
• release/v6.14.16
• nlf/arborist-validation

Build # #2040

Build Type

push

Committed by wraithgar

Commit Message

fix(packages): locale-agnostic string sorting

This adds the 'en' locale to all instances of String.localeCompare
within the CLI codebase.

Tests added for the cases where we're sorting arbitrary user-generated
data.  The tests rely on the fact that 'ch' sorts after 'd' in the
`'sk'` locale, but ahead of `'d'` in the `'en'` locale.  To ensure that
this is the default behavior if no locale is specified, `LC_ALL=sk` is
set in the test environment.

Other instances of `localeCompare` sort data that the cli controls, so
no tests were added.

Re: https://github.com/npm/cli/issues/2829

PR-URL: https://github.com/npm/cli/pull/3203
Credit: @isaacs
Close: #3203
Reviewed-by: @ruyadorno

Run Details

2997 of 3104 branches covered (96.55%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 7 files covered. (100.0%)

5183 of 5345 relevant lines covered (96.97%)

22.78 hits per line