npm / cli / #2040

97%

latest: 97%

push

fix(packages): locale-agnostic string sorting

This adds the 'en' locale to all instances of String.localeCompare
within the CLI codebase.

Tests added for the cases where we're sorting arbitrary user-generated
data.  The tests rely on the fact that 'ch' sorts after 'd' in the
`'sk'` locale, but ahead of `'d'` in the `'en'` locale.  To ensure that
this is the default behavior if no locale is specified, `LC_ALL=sk` is
set in the test environment.

Other instances of `localeCompare` sort data that the cli controls, so
no tests were added.

Re: https://github.com/npm/cli/issues/2829

PR-URL: https://github.com/npm/cli/pull/3203
Credit: @isaacs
Close: #3203
Reviewed-by: @ruyadorno

2997 of 3104 branches covered (96.55%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 7 files covered. (100.0%)

5183 of 5345 relevant lines covered (96.97%)

22.78 hits per line