• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

npm / cli / #2007
97%
latest: 97%

Build:
Build:
LAST BUILD BRANCH: nlf/arborist-validation
DEFAULT BRANCH: latest
Ran 06 May 2021 11:36PM UTC
Jobs 1
Files 122
Run time 17s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
#2007

push

isaacs
Avoid locale-specific string sorting issues

This adds the 'en' locale to all instances of String.localeCompare
within the CLI codebase.

Tests added for the cases where we're sorting arbitrary user-generated
data.  The tests rely on the fact that 'ch' sorts after 'd' in the
`'sk'` locale, but ahead of `'d'` in the `'en'` locale.  To ensure that
this is the default behavior if no locale is specified, `LC_ALL=sk` is
set in the test environment.

Other instances of `localeCompare` sort data that the cli controls, so
no tests were added.

Re: https://github.com/npm/cli/issues/2829

3000 of 3107 branches covered (96.56%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 7 files covered. (100.0%)

5180 of 5342 relevant lines covered (96.97%)

22.79 hits per line

Jobs
ID Job ID Ran Files Coverage
1 #2007.1 06 May 2021 11:36PM UTC 0
96.82
Source Files on build #2007
Detailed source file information is not available for this build.
  • Back to Repo
  • eedb6f00 on github
  • Prev Build on isaacs/locale-compare-en
  • Next Build on isaacs/locale-compare-en
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc