npm / cli / #2007

97%

latest: 97%

push

Avoid locale-specific string sorting issues

This adds the 'en' locale to all instances of String.localeCompare
within the CLI codebase.

Tests added for the cases where we're sorting arbitrary user-generated
data.  The tests rely on the fact that 'ch' sorts after 'd' in the
`'sk'` locale, but ahead of `'d'` in the `'en'` locale.  To ensure that
this is the default behavior if no locale is specified, `LC_ALL=sk` is
set in the test environment.

Other instances of `localeCompare` sort data that the cli controls, so
no tests were added.

Re: https://github.com/npm/cli/issues/2829

3000 of 3107 branches covered (96.56%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 7 files covered. (100.0%)

5180 of 5342 relevant lines covered (96.97%)

22.79 hits per line