nokia / danm

26%

master: 44%

LAST BUILD ON BRANCH tenantnet_setup

branch: tenantnet_setup

CHANGE BRANCH

x

Reset

• tenantnet_setup
• add-copyright-headers
• akraino-install-guide-link
• alloc6_api
• api_group_migration
• binaries
• category_all
• central_ipam_fixes
• cmd_intro
• cni_del_fix
• cni_res_fix
• cnidel_steroid
• cnidel_uts
• concurrent_confman
• configure_naming
• damn-danm
• deploy-guide
• device_handling_fixes
• dis_dad
• dnet_apitype_fix
• dummy_cosmetics
• dummy_encsa
• fix_add_gc
• fix_confman_core
• fix_ip_delegation
• fix_netype_bug
• fix_none_ip
• fixin_uts
• formatting
• go_12_9
• intel_dpdk
• intel_vf_wa
• ip6conf_for_none
• ipam_for_everyone
• ipam_prefix_change
• ipam_store_last_ip
• ipam_uts
• ipv6_cudo
• k8s_1.21_fix
• logo-with-name
• master
• metacni_fourdoto
• netadmit_uts
• netdel_ut
• netwatcher_fourdoto
• netwatcher_healthcheck
• netwatcher_modify
• netwatcher_nad
• networktype_separation
• new_apis
• outage
• perf_fix
• pod_id_to_ep
• prefix_fix
• readme_facelift
• route_device_fix
• route_man_fix
• rutas
• set_ndisc_noti
• slack-links
• store_client
• svcw_update_fix
• svcwatcher_fourdoto
• svcwatcher_healthcheck
• svcwatcher_ns
• svcwatcher_update_eps
• syncher_ut
• tconf_hook_ut
• typo-correction
• uid_weeding
• update_delegation
• v3.2.0
• v3.3.0
• v4.0.0
• v4.1.0
• v4.2.0
• v4.2.0-RC1
• v4.2.0-rc2
• v4.2.0-rc3
• v4.2.1
• v6_alloc
• v6_stat
• validate_max_netmask
• validate_new_apis
• validation_type_change
• versioning
• webhook
• wording/changes
• y_u_no_free

Build # 450

Build Type

Pull #94

travis-ci

Committed by web-flow

Commit Message

Fixing bugs related to Tenantconfig handling.

1: There was a nil pointer reference error in metacni during creation of DANM client
2: IsDynamicBackend incorrectly did not recognize ipvlan as such
3: Accidentally used shallow copy was changed to a (manual, sigh) deep copy when we save the original manifest during net, and conf validation
4: HostDevices list was not properly patched. When changed, the whole JSON list is now put together, and sent for replacement
5: When a host_device or devicepool is explicitly requested, but is not configured, we throw a validation error
6: hostDevices are now filtered, so DevicePools are not accidentally randomly allocated as host_device for a TenantNetwork
7: Mutating VLAN and VxLAN types for accidentally switched up due to wrong condition
8: NetworkIDs were not mutated into the networks because we haven't checked whether they even changed
9: NEtworkID pre-validation was accidentally removed from ClusterNetwork, not from TenantNetwork :)

DISCLAIMER: Freeing VNIs in TenantConfig does not work because K8s does not fill ANY Objects in DELETE requests!!!
Fortunetaly correction is merged, but we need to wait for 1.15.
Til then - no freeing of VNIs.

Pull Request Pull Request #94: DANM 4.0 EP4: Adding the TenantNetwork mutating code to the Webhook.

Run Details

491 of 491 new or added lines in 9 files covered. (100.0%)

541 of 2042 relevant lines covered (26.49%)

6.74 hits per line