nokia / danm / 441

26%

master: 44%

push

travis-ci

Fixing bugs related to Tenantconfig handling.

1: There was a nil pointer reference error in metacni during creation of DANM client
2: IsDynamicBackend incorrectly did not recognize ipvlan as such
3: Accidentally used shallow copy was changed to a (manual, sigh) deep copy when we save the original manifest during net, and conf validation
4: HostDevices list was not properly patched. When changed, the whole JSON list is now put together, and sent for replacement
5: When a host_device or devicepool is explicitly requested, but is not configured, we throw a validation error
6: hostDevices are now filtered, so DevicePools are not accidentally randomly allocated as host_device for a TenantNetwork
7: Mutating VLAN and VxLAN types for accidentally switched up due to wrong condition
8: NetworkIDs were not mutated into the networks because we haven't checked whether they even changed
9: NEtworkID pre-validation was accidentally removed from ClusterNetwork, not from TenantNetwork :)

DISCLAIMER: Freeing VNIs in TenantConfig does not work because K8s does not fill ANY Objects in DELETE requests!!!
Fortunetaly correction is merged, but we need to wait for 1.15.
Til then - no freeing of VNIs.

94 of 94 new or added lines in 6 files covered. (100.0%)

541 of 2073 relevant lines covered (26.1%)

6.64 hits per line