nokia / danm

34%

master: 44%

LAST BUILD ON BRANCH fix_netype_bug

branch: fix_netype_bug

CHANGE BRANCH

x

Reset

• fix_netype_bug
• add-copyright-headers
• akraino-install-guide-link
• alloc6_api
• api_group_migration
• binaries
• category_all
• central_ipam_fixes
• cmd_intro
• cni_del_fix
• cni_res_fix
• cnidel_steroid
• cnidel_uts
• concurrent_confman
• configure_naming
• damn-danm
• deploy-guide
• device_handling_fixes
• dis_dad
• dnet_apitype_fix
• dummy_cosmetics
• dummy_encsa
• fix_add_gc
• fix_confman_core
• fix_ip_delegation
• fix_none_ip
• fixin_uts
• formatting
• go_12_9
• intel_dpdk
• intel_vf_wa
• ip6conf_for_none
• ipam_for_everyone
• ipam_prefix_change
• ipam_store_last_ip
• ipam_uts
• ipv6_cudo
• k8s_1.21_fix
• logo-with-name
• master
• metacni_fourdoto
• netadmit_uts
• netdel_ut
• netwatcher_fourdoto
• netwatcher_healthcheck
• netwatcher_modify
• netwatcher_nad
• networktype_separation
• new_apis
• outage
• perf_fix
• pod_id_to_ep
• prefix_fix
• readme_facelift
• route_device_fix
• route_man_fix
• rutas
• set_ndisc_noti
• slack-links
• store_client
• svcw_update_fix
• svcwatcher_fourdoto
• svcwatcher_healthcheck
• svcwatcher_ns
• svcwatcher_update_eps
• syncher_ut
• tconf_hook_ut
• tenantnet_setup
• typo-correction
• uid_weeding
• update_delegation
• v3.2.0
• v3.3.0
• v4.0.0
• v4.1.0
• v4.2.0
• v4.2.0-RC1
• v4.2.0-rc2
• v4.2.0-rc3
• v4.2.1
• v6_alloc
• v6_stat
• validate_max_netmask
• validate_new_apis
• validation_type_change
• versioning
• webhook
• wording/changes
• y_u_no_free

Build # 276

Build Type

push

travis-ci

Committed by Levovar

Commit Message

Fixing iface deletion bug when netIds don't match

The project assumes that a DanmNet's NetworkID and ObjectMeta.Name parameters always match.
This is even outlined inthe schema descriptor.
However, recently we have introduced some changes which broke this assumption.
First, with the "default" feature, and then lately with the variable static delegate configuration.
The user might not even perceive it, but as a result of these changes interfaces weren't properly cleaned-up during CNI DEL invocations.
Instead of re-writing the whole codebase, we save the real name of the network as well into the interface's DanmEp, and use this parameter when we read the network descriptor during the deletion of the interface.
Meaning of NetworkID parameter left untouched in all the other places, but eventually, we need to revise when to sue which parameter.

Commit contains one more smal,, but important change: the first interface of a Pod will be always named "eth0" from now on.
This change will make it impossible for users to accidentally screw-up network naming, and thus kill their own Pod.

Run Details

555 of 1616 relevant lines covered (34.34%)

9.1 hits per line