nats-io / nats-streaming-server

92%

main: 92%

LAST BUILD ON BRANCH fix_panic_on_redelivery

branch: fix_panic_on_redelivery

CHANGE BRANCH

x

Reset

• fix_panic_on_redelivery
• master
• fix_script_cov
• better_report_client_id_error
• static_channels
• consolidated_config
• fix_flapper
• monitoring
• fix_msg_expiration
• ensure_gofmt_report_error_on_travis
• update_logger
• fix_322
• update_travis
• v0.5.0
• add_opts_clone
• fix_cross_compile
• fix_333
• change_msg_store_apis_to_return_error
• add_arm_6_and_7_builds
• change_sub_store_apis_to_return_error
• fix_monitor_test_data_race
• fix_flapping_tests
• fix_filestore_panic
• store_refactoring
• reduce_test_files_size
• improve_sub_debug_tracing
• split_test_files
• fix_flapping_test
• close_msg_sub_store_on_recovery_failure
• reduce_tests_time
• fix_cmdline_override
• fix_monitor_durable_subs
• system_channel_for_new_channels_notifications
• udpate_ctrl_msg_processing
• fix_timers_and_tune_test
• improve_ctrl_msg_processing
• remove_channel
• common_store_tests
• fix_fstore_expire_panic_on_store_close
• fix_partition_flapping_test
• refactor_store_tests
• add_megacheck
• fix_logtime
• fix_routes_cmdline_override
• fix_queue_stall
• fix_queue_redelivery_on_startup
• improve_sub_stalled_handling
• fix_subs_count
• fix_issue_380
• clustering_mvp_integration
• clustering_spike_v2
• no_close_on_filestore_recover_error
• fix_monitoring_offline_durable_queue_sub
• clustering_sub_failover
• update_vendor_gnatsd
• fix_flags_usage
• close_files_on_recovery
• sql_store
• debug_travis_failing_test
• clustering_ack_replication
• clustering_conn_replication
• raft_sync
• reject_channel_name_with_slash
• clustering_sub_snapshots
• clustering_ack_snapshots
• refactor_queue_groups
• add_arm64_and_docker_multi_platforms
• update_vendors
• prepare_for_next_release
• v0.6.0
• clustering_conn_snapshots
• clustering_upgrade_raft
• clustering_node_id
• clustering_fix_defaults
• clustering_channel_gossip
• clustering_config
• clustering_documentation
• clustering_config_file
• clustering_leader_fix
• clustering_test_fixes
• clustering_recover_fix
• support_sql_ft
• crypto_store_wrapper
• file_encryption
• handle_zeros_at_end_of_files
• add_clientid_in_monitor_chan_subs
• fix_race_on_pubsub_with_partitioning
• ft_retry_on_getexclusivelock_error
• clustering_client_race
• prepare_new_release
• v0.7.0
• sql_fix_first_seq
• fix_ft_and_channel_partitioning
• debug_file_maxage
• fix_filestore_init
• release_072
• v0.7.2
• v0.8.0-beta
• add_arm32v6_docker_build
• delete_ghost_queue_durable_from_store
• fix_display_unlimited_channel_limit
• fix_467
• delete_channel
• fix_flapping_clustering_test
• remove_unnecessary_raft_barrier_calls
• tune_backofftimecheck_flapping_test
• keep_client_id_for_offline_subs_in_monitor_endpoints
• fix_474
• fix_waitnumsubs_helper
• fix_tests_and_travis
• debug_max_age_file_failure
• update_test_dumpfs
• fix_raft_subject_name
• fix_bootstrap
• move_sql_drivers_imports
• fix_crash_on_startup
• update_clustering_tests_can_use_sql
• no_raft_but_streaming_stores
• test_cluster_channel_delete
• expose_nats_options
• fix_snapshot_restore
• fix_delete_channel
• fix_restore_msgs_from_snapshot
• clustering_no_mem_store
• prepare_for_v090
• fix_515
• v0.9.0
• fix_race_tests_setup
• cncf
• remove_nodeid_from_peers
• embed_natslog
• fix_525
• fix_529
• debug_max_inactivity
• fix_maxinactivity_test
• fix_535
• fix_536
• fix_sub_acks_from_older_store
• fs_add_missing_msgs
• fix_520
• fix_logger_and_util_testmain
• v0.9.2
• raft_transport_use_timeout_for_flush
• duplicate_redelivery_on_reconnect
• recover_corrupted_file_store
• fix_559
• add_support_for_client_pings
• update_store_interface
• fix_latest_update_to_sqlstore
• update_client_pings
• update_sql_statement
• update_ping_interval_protocol
• improve_sub_performance
• new_release
• v0.10.0
• fix_test_client_pings_race
• fix_filestore_cache_tests
• fix_client_pings_test
• fix_cluster_sub_start_seq
• fix_client_pings
• fix_sub_stalled_on_recovery
• fix_sub_has_failed_hb
• fix_queue_new_hold
• v0.10.2
• fix_sql_no_caching_on_recovery
• fix_logfile_issues
• add_sigterm_trap
• fix_sql_cache_flush
• fix_ack_processing
• run_as_windows_service
• add_logger_close
• update_vendor
• v0.11.0
• fix_ghost_durables
• queue_sub_ack
• fix_sqlstore_recovery_expire_msgs
• fix_clustering_sub_start_position
• fix_panic_no_leader
• increase_raft_timeouts
• v0.11.2
• fix_max_inactivity
• fix-async-error
• store_encryption
• revisit_fstore_getseqfromtimestamp
• fix_store_encryption
• update_to_staticcheck
• fix_queue_redelivery
• fix_delay_caused_by_invalid_id
• fix_staticcheck_report
• update_to_store_encryption
• update_procfs
• update_boltdb
• update_gnatsd_vendor
• release_0_12_0
• v0.12.0
• fix_snapshot_sub_leak
• fix_race_on_channel_delete
• dont_expose_password_in_trace_and_cb
• add_git_commit_to_docker_file
• cluster_fix_panic_channel_delete
• clustering_fix_install_snapshot_failure
• raft_disable_no_free_list_sync
• release_0_12_2
• v0.12.2
• fix_possible_fs_panic_on_read_index
• remove_go_1_10
• fix_795
• cluster_keep_same_sub_id_on_replay
• fix_791
• fix_792
• release_0_13_0
• release_0_14_0
• v0.14.0
• fix_809
• release_0_14_1
• fix_deadlock
• v0.14.1
• cluster_fix_issue_after_snapshot
• fix_819
• fix_numsubs
• fix_channel_delete
• fix_821
• fix_sql_substore_crash
• fix_834
• fix_833
• raft_shutdown
• cluster_restore_msgs
• release_0_14_2
• v0.14.2
• cluster_msg_store_flush
• release_0_14_3
• v0.14.3
• update_deps
• v0.15.0-RC01
• v0.15.0
• update_dep_to_nats_2_0_0
• release_0_15_1
• v0.15.1
• update_staticcheck
• fix_862
• update
• move_sql_scripts
• fix_869
• filestore_optimizations
• update_nats_server_dep
• add_file_auto_sync
• fix_for_auto_sync
• update_raft_dep
• update_raft_logging
• debug_sql_failing_test
• fix_ft_sql_tick_update
• release_0_16_0
• v0.16.0
• fix_915
• add_streaming_server_ready_log
• fix_921
• fix_go_mod_x_sys
• fix_race_on_delivery_and_store
• fix_930
• fix_934
• paced_sub_start
• handle_fstore_seq_gaps
• david-gurley-natscredentials
• release_0_16_2
• v0.16.2
• fix_950
• update_test_certs
• fix_staticcheck_reports
• fix_974
• add_server_name_and_skip_verify
• change_test_localhost_to_loopback
• fix_raft_logging
• cluster_raft_tport_timeout
• put_back_no_free_list_sync
• fix_993
• update_nats_deps
• add_redelivery_count
• fix_test_sql
• test
• fix_1002
• more_cleanup_on_shutdown
• fix_filestore_empty
• add_flag_to_proceed_on_restore_failure
• fix_snapshot_and_channel_delete
• add_logfile_size_limit
• release_0_17_0
• v0.17.0
• fix_nosyslog_if_logfile_specified
• add-RI-core-maintainer
• add_windows_to_travis
• change_localhost_to_loopback
• fix_1034
• update_bbolt_dep
• fix_622
• fix_test_data_race
• fix_1058
• fix_1060
• fix_1064
• release_0_18_0
• v0.18.0
• fix_1086
• fix_log_cache_issue
• add_remove_cluster_nodes
• fix_990
• fix_panic_on_expire_msgs
• release_0_19_0
• auth_config_file
• add_nkey_support
• fix_1106
• update_go_versions_in_travis
• update_some_deps
• fix_file_slice_max_bytes_cmd_line
• fix_1118
• v0.19.0
• fix_tests
• user_cluster_id_in_internal_subjects
• fix_1135
• fix_1138
• improve_sql_msg_insert_perf
• no_panic_on_unmarshal_errors
• release_0_20_0
• sql_updates
• v0.20.0
• update_protobuf_dep
• sub_set_pend_limits
• add_num_subs_in_monitoring
• cluster_raft_free_list_improvement
• expose_boltdb_conf
• fix_client_health_and_pings
• raftlog_reduce_locking
• bolt_config
• raft_multiple_conns
• fix_sub_req_failed_on_client_close
• close_sub_by_inbox
• release_0_21_0
• v0.21.0
• cluster_fix_transport_panic
• fix_raft_subs
• release_0_21_1
• add_node_id_in_serverz
• v0.21.1
• add-deprecation-notice
• fix_1176
• release_0_21_2
• v0.21.2
• add_clustering_queue_stalled_test
• 1183
• fix_rdlv_count_map
• update_nats_server_deps
• update_stan_go_deps
• release_0_22_0
• v0.22.0
• fix_redeliver_race
• snapshot_qsub_lastsent
• sql_chan_max_seq_from_sub_last_sent
• cluster_raft_tport_shutdown
• main
• release_0_22_1
• v0.22.1
• async_msg_processing
• fix_1189
• clustering_queue_redelivery_changes
• release_0_23_0
• fix_pending_count
• release_0_23_1
• cluster_queue_rdlv
• release_0_23_2
• fix_1229
• report_err_on_chan_create_failure
• go_1_17_and_go_mod
• release_0_24_0
• fix_1235
• release_0_24_1
• fix_1239
• release_0_24_2
• release_0_24_3
• release_0_24_4
• release_0_24_5
• release_0_24_6
• fix_1256
• fix_1255
• add_record_size_limit_parsing
• fix_1261
• revert_record_size_limit
• fix_1263
• fix_sql_server_tests
• fix_code_cov
• fix_1265
• release_0_25_0
• release_0_25_3
• fix_1284
• fix_leadership_acquired
• release_0_25_4
• dependabot/go_modules/github.com/nats-io/nats-server/v2-2.9.23
• dependabot/go_modules/github.com/nats-io/nkeys-0.4.6
• release_0_25_6
• dependabot/go_modules/golang.org/x/crypto-0.17.0
• add-eol-note

Build # 2550

Build Type

push

travis-ci-com

Committed by kozlovic

Commit Message

[FIXED] Possible panic on message redelivery

If the message redelivery callback fired and a client was marked
with failed heartbeat and the subscription is closed (likely
due to the server closing connection due to failed HBs), there
was a race that could cause a panic trying to reset a timer
that has been set to nil.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

12800 of 13974 relevant lines covered (91.6%)

58136.73 hits per line