mbland / custom-links

98%

master: 98%

LAST BUILD ON BRANCH fixups

branch: fixups

CHANGE BRANCH

x

Reset

• fixups
• add-api-for-search
• add-okta
• alpine-fix
• api-json
• autocomplete-and-target-search
• autocomplete-api
• autocomplete-ui
• backend-delete
• bump-npms-and-dockerfile
• cc-test-reporter
• cla-#147
• codeclimate-token
• config-redis
• count-links
• count-to-clicks
• create-and-update-stamps
• create-click-handler
• create-link-view
• create-unknown-link
• deindex-and-reindex
• delete-link
• dialog
• dialog-data
• do-operation
• docker
• dockerize
• downcase-ids
• downcase-users-domains
• edit-link
• edit-link-nonfunctional
• edit-view-support
• empty-hash-view
• env-config-override
• extract-api-helpers
• extract-flash
• fix-error-response
• fix-search-short-links
• fix-smoke-test-flakiness
• focus-element
• headless-chrome
• jsdoc
• launch-redis
• log
• make-api-call
• master
• migrate-autocomplete-target-url-indexes
• my-links
• my-links-buttons
• my-links-e2e
• my-links-landing-page
• readme
• redis-refactor
• redis-shutdown
• refactor
• remove-tabindex
• rename-location-to-target
• rename-redirectdb-to-linkdb
• rename-url-to-link
• save-on-exit
• search-links
• search-on-target-link
• search-ui
• show-timestamps
• show-view-handle-rejection
• show-view-promise
• stabilize-e2e
• style-touchups
• target-index-sets
• transfer-ownership
• travis-ci-fix
• update-npms
• update-packages
• urlp-to-cl
• v0.1.0
• v0.1.1
• v0.1.2
• v0.2.0
• v0.2.1
• v0.3.0
• view-and-backend
• wait-for-redis

Build # 391

Build Type

push

travis-ci

Committed by mbland

Commit Message

public: Handle net::ERR_CONNECTION_REFUSED in XHR

As it turns out, the `XMLHttpRequest.onerror` handler won't handle
`net::ERR_CONNECTION_REFUSED` or other network errors. For that, one
needs to check for `xhr.status === 0` after `xhr.readyState === 4`.

The problem manifest when manually testing to simulate a link deletion
request failure by killing the server, and there was no accompanying
error message as expected from the `onerror` handler. The hint for the
solution came from:

https://stackoverflow.com/questions/28556398/how-to-catch-neterr-connection-refused

Run Details

241 of 265 branches covered (90.94%)

Branch coverage included in aggregate %.

1899 of 1921 relevant lines covered (98.85%)

12.43 hits per line