mbland / custom-links / 391

98%

master: 98%

push

travis-ci

public: Handle net::ERR_CONNECTION_REFUSED in XHR

As it turns out, the `XMLHttpRequest.onerror` handler won't handle
`net::ERR_CONNECTION_REFUSED` or other network errors. For that, one
needs to check for `xhr.status === 0` after `xhr.readyState === 4`.

The problem manifest when manually testing to simulate a link deletion
request failure by killing the server, and there was no accompanying
error message as expected from the `onerror` handler. The hint for the
solution came from:

https://stackoverflow.com/questions/28556398/how-to-catch-neterr-connection-refused

241 of 265 branches covered (90.94%)

Branch coverage included in aggregate %.

1899 of 1921 relevant lines covered (98.85%)

12.43 hits per line