loot / libloot

94%

master: 94%

LAST BUILD ON BRANCH unique-plugin-interface

branch: unique-plugin-interface

CHANGE BRANCH

x

Reset

Sync Branches

• unique-plugin-interface
• actions-permissions
• add-audits
• better-error-line-numbers
• c++20
• c++20-wrapper
• c4711
• cargo-vet
• ci-npm-cache
• ci-updates
• cmake-vars
• coverage-ci
• cxx-fix
• decouple-condition-cache
• dependency-notices
• disable-cxx-lto
• emit-anchors-aliases
• fix-dependabot
• fix-metadata-write
• fix-msvc-warning
• fix-node-vulns
• fix-permission
• improve-readmes
• master
• misc
• misc-changes
• misc-fixes
• prep-0.28.2
• prevent-base-class-slicing
• regex-fix
• regress
• release-0.28.4
• remove-32-bit-builds
• rename-target
• replace-install-action
• rust-rewrite
• support-symlinks
• symlink-support
• test-long-paths
• undo-cargo-toml-change
• update-audits
• update-c++-game-wrapper
• update-cxx
• update-deps
• update-doc
• update-docs
• update-lci
• update-locks
• update-napi-build
• update-napi-derive
• update-napi-rs
• update-nodejs-lockfiles
• update-regress
• update-release-job
• update-rust-ini
• update-unicase
• userlist-parity
• uv-ci
• yaml-fixes

Build # 20677970354

Build Type

push

github

Committed by Ortham

Commit Message

Use unique_ptr instead of shared_ptr for PluginInterface pointers

unique_ptr is simpler, and can be easily converted to shared_ptr if needed, and makes it obvious that each call will return a new pointer.

This does mean that if I want to hold onto the objects again in the future for some reason, that'll need the API to change back, but that seems unlikely.

unique_ptr not being copyable does make using it a little more awkward, but that only happened in one place in LOOT's code, and there the pointer needs to become shared anyway.

Run Details

12244 of 13050 relevant lines covered (93.82%)

143.08 hits per line