liran-funaro / fabric-x-committer / 29742436279

92%

Build Type

push

github

Committed by web-flow

Commit Message

[retry] Support unlimited retries via max-elapsed-time (#684)

#### Type of change

- Improvement

#### Description

- Make `retry.Profile.MaxElapsedTime` a `*time.Duration` so an operator
can request unlimited retries via `max-elapsed-time: 0`. This enables
dynamic scaling of pre-configured instances: the coordinator/sidecar
keep reconnecting to instances that are stopped/started at runtime
instead of giving up after the default 15m budget.

#### Changes

- Semantics: `nil` (unset) → default 15m (unchanged); `0` → unlimited;
positive → that budget. A `validate:"omitempty,gte=0"` tag rejects
negative values at config load.
- Unlimited retries are provided by the backoff/`Sustain` layer
(`WithMaxElapsedTime(0)`). The gRPC retry policy has no unlimited
option, so it stays intentionally bounded at `defaultGrpcMaxAttempts`
and relies on `Sustain` to re-establish the connection (service
reconnection only).
- Rewrite `connection.CalcMaxAttempts` as a closed-form formula instead
of a loop (behavior-preserving; validated by the unchanged existing test
vectors).
- Document the dynamic-scaling retry-budget guidance and the `0 =
unlimited` option in the deployment guide and sample configs.

#### Related issues

- Resolves #679

---------

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

26 of 26 new or added lines in 3 files covered. (100.0%)

64 existing lines in 9 files now uncovered.

10462 of 11410 relevant lines covered (91.69%)

43113.6 hits per line