kaidokert / xacro

89%

main: 94%

LAST BUILD ON BRANCH feature/pow-preprocessing-fix

branch: feature/pow-preprocessing-fix

CHANGE BRANCH

x

Reset

• feature/pow-preprocessing-fix
• blep
• chore/cleanup-tests-and-readme
• feat/ancestor-package-detection
• feat/arg
• feat/array_indexing
• feat/atan2
• feat/blah
• feat/cleanp2
• feat/cleanup_refactor
• feat/cli-tool-start
• feat/doc
• feat/duplicate_params
• feat/examples
• feat/ext_1
• feat/ext_2
• feat/f1
• feat/f3
• feat/final-privatization
• feat/fix-namespaces
• feat/fix_conditionals
• feat/float_output
• feat/hide_modules
• feat/layers
• feat/lazy_prop
• feat/lenient_missing_files
• feat/macro_eval_fix
• feat/math_constants
• feat/math_fixes
• feat/missing_math
• feat/moreclean
• feat/moretest
• feat/namespace-variants
• feat/namespace_compat
• feat/namespace_fallback_fix
• feat/namespace_fix
• feat/namespace_tweak
• feat/nanan
• feat/package-tracking
• feat/patch_py
• feat/print_loc
• feat/processing_instructions
• feat/pub4
• feat/radians
• feat/relazy_eval
• feat/rename-xacro-rs
• feat/scoping_bugfix
• feat/singlepass_squash
• feat/squash_float_meta
• feat/stdin-support
• feat/test_squash2
• feat/unpub-internals
• feat/up_v16
• feat/update_read
• feat/xml_output
• feat/xmltree
• feat/yaml-unit-tags
• feat/yaml_loading
• feature/add-github-ci
• feature/cwd-extension
• feature/deps-flag
• feature/macro-processing-improvements
• feature/package-map-delimiter-fix
• feature/package-map-env-var
• feature/phase3-insert-block
• feature/property-type-preservation
• feature/pyisheval_and_or_operators
• feature/scope_manipulation
• fix/attribute-whitespace-normalization
• fix/block-param-lazy-property-precedence
• fix/block-param-star-distinction
• fix/boolean-metadata-propagation
• fix/boolean-output
• fix/builtin-shadowing
• fix/canonical
• fix/circular-dependency-false-positives
• fix/circular-dependency-false-positives1
• fix/defensive-slice-temp-filename
• fix/eval-literal-case-insensitive
• fix/extension-argument-evaluation
• fix/macro-expression-evaluation
• fix/namespace-collision-prefix-check
• fix/namespace-output-cleanup
• fix/package-map-trust-explicit
• fix/property-scoping-interpreter-leak
• fix/true-false-type-coercion
• fix_macro_bug
• foo
• macro_defaults
• macro_parser_bug
• main
• paramless_macro
• polish/docs-and-cleanup
• pr2/math-functions
• pr4a/none-constant
• pr4b/macro-name-fix
• pr5/pyisheval-v0.14
• pyish11
• refactor-expander
• refactor-scope-squashed
• refactor/yam_tag_handlers
• refactor_followup

Build # 21131984119

Build Type

Pull #76

github

Committed by kaidokert

Commit Message

Address additional PR review feedback

1. Improve eval_math_arg macro error reporting
   - Add warning when non-numeric value encountered
   - Include actual value in warning message for debugging
   - Helps identify type mismatches during preprocessing

2. Improve readability: Rename not_in_string() to in_string()
   - Eliminates double-negation (!not_in_string())
   - More intuitive method name
   - Updated all 3 call sites

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Pull Request Pull Request #76: Fix misleading 'Undefined variable: pow' error in math preprocessor

Run Details

45 of 66 new or added lines in 1 file covered. (68.18%)

4899 of 5511 relevant lines covered (88.89%)

277.03 hits per line