kaidokert / xacro / 21131127108

89%

main: 94%

Pull #76

github

Fix misleading 'Undefined variable: pow' error in math preprocessor

When a variable inside a math function call (like pow(x, 2)) was
undefined, the preprocessor would silently skip the replacement,
leaving the raw text "pow(x, 2)" for pyisheval to evaluate. Since
pyisheval doesn't know what pow is, it would report "Undefined
variable: pow" instead of "Undefined variable: x".

Root cause: In preprocess_math_functions(), when argument evaluation
failed, we used pattern matching with if-let that silently continued
to the next match on error. This masked the true error.

Fix: Explicitly match on eval results and propagate errors immediately
when argument evaluation fails. Now users see the real problem:
the undefined variable in the argument, not the function name.

Added tests to verify both single-arg (cos) and two-arg (pow) cases
report the correct undefined variable.

Fix pow() preprocessing in arithmetic parentheses

Math function preprocessing used at_top_level() which excluded
functions inside ANY parentheses, including arithmetic ones like
m*(3*pow(r,2)). Added not_in_string() to only check quotes,
allowing math functions in arithmetic expressions.

58 of 83 new or added lines in 1 file covered. (69.88%)

4912 of 5528 relevant lines covered (88.86%)

273.21 hits per line