kaidokert / xacro / 21131571324

89%

main: 94%

Pull #76

github

Address PR review feedback: performance, testing, and code quality

1. Performance: Extract eval_math_arg macro to reduce duplication
   - Consolidates argument evaluation logic used 3 times
   - Improves maintainability and reduces code size

2. Testing: Add comprehensive masked error tests
   - Added tests for log() with undefined arguments (2 tests)
   - Added tests for atan2() with undefined arguments (2 tests)
   - Covers all multi-arg math functions for error reporting

3. Testing: Add string literal preprocessing verification
   - Confirms pow()/pi in quoted strings are not preprocessed
   - Critical test for not_in_string() behavior change

4. Testing: Replace /tmp hardcoded paths with tempfile
   - Uses tempfile::NamedTempFile for all temporary files
   - Improves test isolation and cross-platform compatibility

5. Code quality: Use idiomatic .get().map() for char access
   - More concise and safer than manual bounds checking

6. Code quality: Add truncation to large debug logs
   - Prevents bloat from logging large expressions
   - Logs length + truncated preview instead of full content

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

45 of 66 new or added lines in 1 file covered. (68.18%)

4899 of 5511 relevant lines covered (88.89%)

277.02 hits per line