jakirkham / dask-distance

100%

master: 100%

LAST BUILD ON BRANCH drop_cdist_fin_rchk

branch: drop_cdist_fin_rchk

CHANGE BRANCH

x

Reset

• drop_cdist_fin_rchk
• add__atleast_2d
• add__bool_dist
• add__concatenate
• add__pycompat
• add_accumulate
• add_atop_ravel
• add_bool_dist
• add_bool_dist_title
• add_braycurtis
• add_canberra
• add_cdist
• add_chebyshev
• add_cityblock
• add_compat
• add_correlation
• add_cosine
• add_dice
• add_euclidean
• add_hamming
• add_izip
• add_jaccard
• add_kulsinski
• add_mahalanobis
• add_minkowski
• add_pdist
• add_rogerstanimoto
• add_russellrao
• add_seuclidean
• add_sokalmichener
• add_sokalsneath
• add_sqeuclidean
• add_squareform
• add_wminkowski
• add_yule
• adj_cdist_asarray
• adj_hamming
• adj_hamming_sum
• broadcast_uv_wrapper
• ci_run_flake8
• cmp_many_bool_arrays
• comb_bool_cmp
• cond_def_pdist_kwargs
• d_zeros_array_squareform
• dist_more_metrics
• dist_use_kwargs
• dists_doc_more_kwargs
• drop_broadcast_repeat
• drop_dask_ver_chck
• drop_dice_docs_dot
• enforce_1d_bool_arrs
• fix_euclidean_doc
• fix_license_typo
• fix_mahalanobis_doc_typo
• fix_pdist_bug
• fix_pdist_metric_def
• fix_ravel_chks
• fix_seuclidean_equ
• fix_utils_tst_name
• flake8_fixes
• master
• opt_dist_ident
• opt_gen_pdist_diag
• opt_gen_pdist_diag_2
• opt_gen_pdist_diag_recrsv
• opt_pdist_diag
• opt_squareform
• pdist_doc_more_kwargs
• pdist_grp_cdist_comps
• pdist_knwn_shape
• pdist_norm_arr
• pdist_store_mask
• pdist_use_pycompat_range
• ravel_no_concat
• rchk_lst_z_squareform
• ref_broadcast_uv
• ref_math_expr
• rename_uv_mtx
• req_numpy_dask
• req_scipy_tsts
• rfrsh_dim_check
• simp_cdist_apply
• sp_case_ravel
• sty_fix__cdist_apply
• support_1pt_pdist
• temp
• tidy_formulae
• tst_2d_more_shapes
• tst_cdist_shapes
• tst_wrong_lengths
• tsts_w_kw
• tweak_cdist_conv
• tweak_tst_comp
• use_cookiecutter
• use_mathjax_docs
• use_minkowski_dist_mat
• use_rel_imp
• v0.1.0
• v0.2.0
• vendor_indices
• wrap_braycurtis_doc

Build # 502

Build Type

push

travis-ci

Committed by jakirkham

Commit Message

Drop rechunking of cdist's result

There should be no need to rechunk `cdist`'s result to match the input
arrays. After all this chunking should just fall out from the operations
that we have done in `cdist`. The only way the chunks would not match is
if there was some rechunking done behind the scenes. If rechunking was
done behind the scenes, there probably was a reason for it and thus we
should leave the result's chunks alone.

This rechunking was likely added to guarantee that `pdist`'s
`triu`-based optimization strategy would work (as `triu` requires square
chunks). However we have dropped the `triu`-based optimization from
`pdist` in favor of slicing out the relevant pieces to keep ourselves.
So there is no requirement from `pdist` to have `cdist` rechunk the
result.  Further if we did readd some `triu`-based optimization to
`pdist`, it would be up to `pdist` to guarantee the chunking was
appropriate. So `pdist`'s former requirement should not constrain
`cdist`'s result's chunks.

Run Details

289 of 289 relevant lines covered (100.0%)

3.97 hits per line