ilai-deutel / kibi
75%

DEFAULT BRANCH: master
Repo Added
Files 11
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x

coverage: 75.304% (+4.2%) from 71.134%
40589539477

push

github

web-flow 
Add Ctrl-O to open a file (#651)

* Add Ctrl-O to open a file

Fixes #647

* Fix lines-of-code check: reuse load() for buffer replacement

Move the buffer-replacement and file-name/syntax setup into load() so
Editor::run and the new open() share one code path, keeping the total
under the 1024-line limit (unix: 1024). A Ctrl-O open of a missing
file now also sets the file name, matching the CLI behavior.

* Skip filesystem-dependent tests on WASI

The open-file tests use tempfile, which requires std::env::temp_dir().
That function panics on WASI ("not supported by WASI yet"), so the two
new tests failed on the wasm32-wasip1 CI targets. Move them into a
submodule gated on not(target_family = "wasm"), matching how config.rs
and syntax.rs gate their filesystem tests.

* Address review: readable open errors, no-op on invalid files, open() in run()

- load() returns io::Error; open() prints the path and uses Display
- the file-type check runs before syntax/file_name/rows are updated, so
  opening an invalid file leaves the buffer untouched
- run() opens the start file through open() like nano and vi: the editor
  starts and shows the error in the status bar instead of exiting
- rebase onto master (which grew the LOC budget back to the 1024 limit)

* Check file type before opening to fix Windows test failure

File::open on a directory fails with Access denied on Windows before the
type check runs, so editor_open_invalid_file_type_is_noop failed on all
Windows targets. Check the type with fs::metadata before opening instead.

* Clear the buffer when opening a missing file

Opening a path that does not exist kept the previous rows and appended
the new empty row to them. Replace the buffer before the file-open
branch so a missing file starts a fresh empty buffer, with a regression
test.

Also apply the current nightly rustfmt reflows (CI runs cargo fmt on
the PR head) and inline the file-type check to keep the unix LOC count
at 1024.

---------

69 of 76 new or added lines in 1 file covered. (90.79%)

1 existing line in 1 file now uncovered.

991 of 1316 relevant lines covered (75.3%)

1014.3 hits per line

Relevant lines Covered
1316 RELEVANT LINES 991 COVERED LINES
1014.3 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
40589539477 master Add Ctrl-O to open a file (#651) * Add Ctrl-O to open a file Fixes #647 * Fix lines-of-code check: reuse load() for buffer replacement Move the buffer-replacement and file-name/syntax setup into load() so Editor::run and the new open() share o... push web-flow github
75.3
40588742045 dependabot/cargo/rstest-0.28.0 Bump rstest from 0.27.0 to 0.28.0 Bumps [rstest](https://github.com/la10736/rstest) from 0.27.0 to 0.28.0. - [Release notes](https://github.com/la10736/rstest/releases) - [Changelog](https://github.com/la10736/rstest/blob/master/CHANGELOG.md) - [... Pull #663 web-flow github
71.13
40588491684 dependabot/github_actions/github/codeql-action/analyze-4.38.2 Bump github/codeql-action/analyze from 4.35.3 to 4.39.1 Bumps [github/codeql-action/analyze](https://github.com/github/codeql-action) from 4.35.3 to 4.39.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https:/... Pull #660 web-flow github
71.13
40588349097 dependabot/cargo/libc-0.2.191 Bump libc from 0.2.189 to 0.2.191 Bumps [libc](https://github.com/rust-lang/libc) from 0.2.189 to 0.2.191. - [Release notes](https://github.com/rust-lang/libc/releases) - [Changelog](https://github.com/rust-lang/libc/blob/0.2.191/CHANGELOG.md) - ... Pull #662 web-flow github
71.13
40587616933 dependabot/github_actions/step-security/harden-runner-2.21.1 Bump step-security/harden-runner from 2.20.0 to 2.22.2 Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.20.0 to 2.22.2. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commit... Pull #659 web-flow github
71.13
40587584009 dependabot/github_actions/Swatinem/rust-cache-2.9.2 Merge branch 'master' into dependabot/github_actions/Swatinem/rust-cache-2.9.2 Pull #643 web-flow github
71.13
40587356063 ctrl-o-open-file Merge ee3f7a434 into ccfcde57e Pull #651 web-flow github
75.3
40587115248 master Bump MSRV to 1.99 push ilai-deutel github
71.13
40456718747 push-mrxyyosrvwkp Bump MSRV to 1.99 Pull #658 ilai-deutel github
71.13
40456502672 push-kpzlppvoqqyt Comply with new nightly rustfmt Pull #664 ilai-deutel github
71.13
See All Builds (320)