ilai-deutel / kibi / 40589539477

75%

Build Type

push

github

Committed by web-flow

Commit Message

Add Ctrl-O to open a file (#651)

* Add Ctrl-O to open a file

Fixes #647

* Fix lines-of-code check: reuse load() for buffer replacement

Move the buffer-replacement and file-name/syntax setup into load() so
Editor::run and the new open() share one code path, keeping the total
under the 1024-line limit (unix: 1024). A Ctrl-O open of a missing
file now also sets the file name, matching the CLI behavior.

* Skip filesystem-dependent tests on WASI

The open-file tests use tempfile, which requires std::env::temp_dir().
That function panics on WASI ("not supported by WASI yet"), so the two
new tests failed on the wasm32-wasip1 CI targets. Move them into a
submodule gated on not(target_family = "wasm"), matching how config.rs
and syntax.rs gate their filesystem tests.

* Address review: readable open errors, no-op on invalid files, open() in run()

- load() returns io::Error; open() prints the path and uses Display
- the file-type check runs before syntax/file_name/rows are updated, so
  opening an invalid file leaves the buffer untouched
- run() opens the start file through open() like nano and vi: the editor
  starts and shows the error in the status bar instead of exiting
- rebase onto master (which grew the LOC budget back to the 1024 limit)

* Check file type before opening to fix Windows test failure

File::open on a directory fails with Access denied on Windows before the
type check runs, so editor_open_invalid_file_type_is_noop failed on all
Windows targets. Check the type with fs::metadata before opening instead.

* Clear the buffer when opening a missing file

Opening a path that does not exist kept the previous rows and appended
the new empty row to them. Replace the buffer before the file-open
branch so a missing file starts a fresh empty buffer, with a regression
test.

Also apply the current nightly rustfmt reflows (CI runs cargo fmt on
the PR head) and inline the file-type check to keep the unix LOC count
at 1024.

---------

Coverage Stats

69 of 76 new or added lines in 1 file covered. (90.79%)

1 existing line in 1 file now uncovered.

991 of 1316 relevant lines covered (75.3%)

1014.3 hits per line