hyperledger-labs / fabric-smart-client / 29484837588

81%

push

github

fix(metrics): cache collectors in the prometheus provider (#1582)

* fix(metrics): cache collectors in the prometheus provider

Repeated requests for the same metric built a fresh collector whose
registration failed; with SkipRegisterErr set the error was swallowed
and the collector was silently left unregistered. Cache collectors by
kind and fully-qualified name so repeated requests share the collector
registered first and skip the registry, and fail with a descriptive
error when a name is reused with different options or an incompatible
collector type.

Fixes #1581

Signed-off-by: Evan <evanyan@sign.global>

* fix(metrics): drop SkipRegisterErr and exclude LabelHelp from cache checks

Address review feedback on the collector cache:
- exclude the doc-only LabelHelp field from the cached definition so
  requests differing only in label documentation share the collector
- remove SkipRegisterErr: the cache and the AlreadyRegisteredError
  handling cover duplicate registration, so the remaining failures are
  programming errors that should fail fast instead of silently handing
  out collectors that are invisible on /metrics
- cover reuse of a collector registered outside the provider

Signed-off-by: Evan <evanyan@sign.global>

---------

Signed-off-by: Evan <evanyan@sign.global>

75 of 78 new or added lines in 3 files covered. (96.15%)

28894 of 39027 relevant lines covered (74.04%)

2761.99 hits per line