helpscout / blue

100%

master: 100%

LAST BUILD ON BRANCH PortalWrapper/remove-body-lock

branch: PortalWrapper/remove-body-lock

CHANGE BRANCH

x

Reset

• PortalWrapper/remove-body-lock
• ChatList-component
• SidebarCollapsibleCard/improve-sorting
• add-back-icon
• add-checkbox
• add-grid-component
• add-helix
• add-progress-bar
• add-utils-to-main
• alert-component
• avatar-initials
• better-bundling
• bind-performance
• card-enhance
• card-onclick
• card-resolve-classname
• card/add-link-component-integration
• card/link-background-color
• choice-fix-id
• css/input-and-select-for-vendors
• dragon-drop
• drop/composedcomponent-props
• dropdown
• dropdown/cani
• dropdown/simplify-positioning
• emoji-picker
• enum-proptypes
• exp-popoverwrapper
• feature/add-hint-text-to-input
• fix-animate-classname
• fix-portal-test
• fix-sortable-component-prop
• fix/import-path
• hs-app-slim
• hs-app-theme
• improve-component-exports
• improve-component-props
• improve-portal-mount-cycle
• infinite-scroll
• infinite-scroll/improve-scroll-position
• infinite-scroller/improve-callback-events
• input/fix-autocomplete-styles
• input/multiline-ghost-overflow
• keypresslistener/work-with-iframes
• list-component
• loading-dots/add-alignment
• master
• message-component
• modal/fix-scrollable-padding-issue
• prevent-default-on-link-click
• progress-bar-accessibility
• resolve-dependencies
• router-wrapper
• samp-code-components
• sidebar-collapsible-card-toggle-open-with-props
• sidebar-expandable-card
• skeleton-component
• sortable-props-issue
• storybook
• switch-component
• timeline-component
• truncate-component
• update-gitignore-and-package
• v0.0.10
• v0.0.11
• v0.0.12
• v0.0.13
• v0.0.14
• v0.0.15
• v0.0.16
• v0.0.17
• v0.0.18
• v0.0.19
• v0.0.20
• v0.0.21
• v0.0.22
• v0.0.23
• v0.0.24
• v0.0.25
• v0.0.26
• v0.0.27
• v0.0.28
• v0.0.29
• v0.0.30
• v0.0.33
• v0.0.35
• v0.0.36
• v0.0.37
• v0.0.38
• v0.0.39
• v0.0.40
• v0.0.41
• v0.0.42
• v0.0.43
• v0.0.43-beta
• v0.0.43-beta.1
• v0.0.44
• v0.0.45
• v0.0.46
• v0.0.47
• v0.0.48
• v0.0.49
• v0.0.5
• v0.0.50
• v0.0.51
• v0.0.52
• v0.0.53
• v0.0.54
• v0.0.55
• v0.0.6
• v0.0.7
• v0.0.8
• v0.0.9

Build # 499

Build Type

push

travis-ci

Committed by ItsJonQ

Commit Message

PortalWrapper: Remove body lock

This update removes the `document.body.style.overflow: hidden` approach,
which was previously used as an attempt to scroll lock the body
if components like Modals were open.

However, this approach has side effects, such as if Modals were
used within an iframe.

A couple of updates back, we introduced a new component called
`<ScrollLock>` (which has been built into `<Scrollable>`, and indirectly,
`<Modal>`) which magically remedies these issues.

`Modal` and `PortalWrapper` components have been updated to remove
any trace of `body` locking, and the tests have been updated to match.

No changes are required for Blue users!

Run Details

1084 of 1084 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1751 of 1751 relevant lines covered (100.0%)

102.71 hits per line