helpscout / blue

100%

master: 100%

LAST BUILD ON BRANCH choice-fix-id

branch: choice-fix-id

CHANGE BRANCH

x

Reset

• choice-fix-id
• master
• v0.0.5
• v0.0.6
• v0.0.7
• add-checkbox
• v0.0.8
• hs-app-theme
• v0.0.9
• improve-component-props
• v0.0.10
• improve-portal-mount-cycle
• v0.0.11
• add-back-icon
• add-grid-component
• v0.0.12
• v0.0.13
• v0.0.14
• add-utils-to-main
• fix/import-path
• add-progress-bar
• progress-bar-accessibility
• v0.0.15
• hs-app-slim
• v0.0.16
• router-wrapper
• enum-proptypes
• v0.0.17
• exp-popoverwrapper
• fix-animate-classname
• v0.0.18
• improve-component-exports
• v0.0.19
• card-enhance
• v0.0.20
• v0.0.21
• sidebar-expandable-card
• v0.0.22
• sidebar-collapsible-card-toggle-open-with-props
• v0.0.23
• bind-performance
• dragon-drop
• v0.0.24
• dropdown
• avatar-initials
• v0.0.25
• sortable-props-issue
• v0.0.26
• fix-portal-test
• message-component
• emoji-picker
• v0.0.27
• storybook
• feature/add-hint-text-to-input
• v0.0.28
• update-gitignore-and-package
• resolve-dependencies
• v0.0.29
• v0.0.30
• prevent-default-on-link-click
• infinite-scroll
• fix-sortable-component-prop
• card-resolve-classname
• v0.0.33
• modal/fix-scrollable-padding-issue
• v0.0.35
• card/add-link-component-integration
• v0.0.36
• loading-dots/add-alignment
• card/link-background-color
• v0.0.37
• infinite-scroll/improve-scroll-position
• v0.0.38
• infinite-scroller/improve-callback-events
• v0.0.39
• SidebarCollapsibleCard/improve-sorting
• v0.0.40
• css/input-and-select-for-vendors
• v0.0.41
• better-bundling
• v0.0.42
• v0.0.43-beta
• v0.0.43-beta.1
• v0.0.43
• card-onclick
• v0.0.44
• alert-component
• v0.0.45
• v0.0.46
• list-component
• v0.0.47
• keypresslistener/work-with-iframes
• v0.0.48
• switch-component
• v0.0.49
• input/fix-autocomplete-styles
• v0.0.50
• dropdown/cani
• v0.0.51
• input/multiline-ghost-overflow
• samp-code-components
• dropdown/simplify-positioning
• v0.0.52
• drop/composedcomponent-props
• add-helix
• timeline-component
• v0.0.53
• truncate-component
• v0.0.54
• skeleton-component
• v0.0.55
• ChatList-component
• PortalWrapper/remove-body-lock

Build # 61

Build Type

push

travis-ci

Committed by ItsJonQ

Commit Message

Choice: Fix ID generation

This update fixes the `uniqueID()` generation for the `Choice` component, which indirectly fixes it for `Checkbox` and `Radio`. The same fix was also applied to `Input` and `PortalWrapper`.

This issue was the element's ID was being regenerated everytime there was a prop change, which is incorrect. It should only be generated once. The solution was to generate and store the uniqueID in the component state, instead of creating it in the render hook.

The uniqueID creation factory function has also been enhanced to accept a prefix override namespace.

Run Details

345 of 345 branches covered (100.0%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 5 files covered. (100.0%)

564 of 564 relevant lines covered (100.0%)

35.43 hits per line