helpscout / blue

100%

master: 100%

LAST BUILD ON BRANCH improve-portal-mount-cycle

branch: improve-portal-mount-cycle

CHANGE BRANCH

x

Reset

• improve-portal-mount-cycle
• ChatList-component
• PortalWrapper/remove-body-lock
• SidebarCollapsibleCard/improve-sorting
• add-back-icon
• add-checkbox
• add-grid-component
• add-helix
• add-progress-bar
• add-utils-to-main
• alert-component
• avatar-initials
• better-bundling
• bind-performance
• card-enhance
• card-onclick
• card-resolve-classname
• card/add-link-component-integration
• card/link-background-color
• choice-fix-id
• css/input-and-select-for-vendors
• dragon-drop
• drop/composedcomponent-props
• dropdown
• dropdown/cani
• dropdown/simplify-positioning
• emoji-picker
• enum-proptypes
• exp-popoverwrapper
• feature/add-hint-text-to-input
• fix-animate-classname
• fix-portal-test
• fix-sortable-component-prop
• fix/import-path
• hs-app-slim
• hs-app-theme
• improve-component-exports
• improve-component-props
• infinite-scroll
• infinite-scroll/improve-scroll-position
• infinite-scroller/improve-callback-events
• input/fix-autocomplete-styles
• input/multiline-ghost-overflow
• keypresslistener/work-with-iframes
• list-component
• loading-dots/add-alignment
• master
• message-component
• modal/fix-scrollable-padding-issue
• prevent-default-on-link-click
• progress-bar-accessibility
• resolve-dependencies
• router-wrapper
• samp-code-components
• sidebar-collapsible-card-toggle-open-with-props
• sidebar-expandable-card
• skeleton-component
• sortable-props-issue
• storybook
• switch-component
• timeline-component
• truncate-component
• update-gitignore-and-package
• v0.0.10
• v0.0.11
• v0.0.12
• v0.0.13
• v0.0.14
• v0.0.15
• v0.0.16
• v0.0.17
• v0.0.18
• v0.0.19
• v0.0.20
• v0.0.21
• v0.0.22
• v0.0.23
• v0.0.24
• v0.0.25
• v0.0.26
• v0.0.27
• v0.0.28
• v0.0.29
• v0.0.30
• v0.0.33
• v0.0.35
• v0.0.36
• v0.0.37
• v0.0.38
• v0.0.39
• v0.0.40
• v0.0.41
• v0.0.42
• v0.0.43
• v0.0.43-beta
• v0.0.43-beta.1
• v0.0.44
• v0.0.45
• v0.0.46
• v0.0.47
• v0.0.48
• v0.0.49
• v0.0.5
• v0.0.50
• v0.0.51
• v0.0.52
• v0.0.53
• v0.0.54
• v0.0.55
• v0.0.6
• v0.0.7
• v0.0.8
• v0.0.9

Build # 42

Build Type

push

travis-ci

Committed by ItsJonQ

Commit Message

Improve Portal mount cycle

This update improves the lifecycle callbacks for Portal and PortalWrapper. Portal has been adjusted to allow for re-rendering of child components based on prop changes, which is handy (and necessary) for things like child unmounting animations or `style` prop changes (will come in handy for `Popover`/`Tooltip`).

A new prop from Portal has been exposed in PortalWrapper called `isMounted`. It is similar to `isOpen`, but it's state is changed slightly before `isOpen`, allowing for child components to execute callbacks that need to happen  before the Portal child is removed from the DOM (like Animations).

Previous component APIs are not affected, therefore nothing is required for the user/consumer of Blue components.

Tests + README documentation has been updated.

Run Details

302 of 302 branches covered (100.0%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 2 files covered. (100.0%)

515 of 515 relevant lines covered (100.0%)

36.9 hits per line