floatdrop / moq-go

89%

LAST BUILD ON BRANCH draft-19

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• chore/drop-relay-nats
• ci/coveralls
• draft-19
• fix/flaky-tests
• fix/gate-etcd-and-wt
• fix/stitch-harness-flake
• test/conn-conformance
• test/datagrams-over-real-transports
• test/etcd-largest-object
• test/fault-injecting-conn
• test/fetch-merge-edges
• test/fetch-rejection-codes
• test/fetch-upstream-edges
• test/msf-coverage
• test/relay-etcd-coverage
• test/session-gaps

Build # 31777712475

Build Type

push

github

Committed by floatdrop

Commit Message

test(session): cover the error message and parse-failure branch of track properties

Two blocks in track_properties.go were reached by nothing.

ErrUnsupportedMandatoryTrackProperty.Error() sat at 0%. It is an exported,
log-facing message carrying a §2.5.1 reference, and all four existing
tests match the error by type via errors.As without ever formatting it —
so a mangled format verb would have shipped silently.

The parse-failure branch of ValidateTrackProperties was the other: no
test fed it bytes that fail to decode. The new one also asserts the
result is NOT *ErrUnsupportedMandatoryTrackProperty, because §2.5.1
attaches specific remedies to that error (REQUEST_ERROR /
UNSUPPORTED_EXTENSION on PUBLISH, cancelling the subscription or fetch
per §3.3.3 on SUBSCRIBE_OK / FETCH_OK) and none of them fit Track
Properties that simply would not decode.

Both verified red first by mutating the source, each failing only its own
test: dropping the 0x prefix from the format string, and swallowing the
parse error. The message assertion was re-verified after being rewritten
from full-string equality to substrings, and now catches two mutations
rather than one (0x%X -> %X and 0x%X -> 0x%d).

It asserts substrings deliberately. Full-string equality breaks on any
behaviour-neutral rewording, and it cannot catch the stale section number
it appears to guard: the expected text is a copy of the format string, so
a draft renumbering edits both together and the test stays green.

§2.5.1 and §1.4.3 were both checked against draft-ietf-moq-transport-19
itself. 0x02 is a one-byte Delta Type varint resolving to Type 2 (first
pair, running total starts at zero); an even Type carries a varint value,
truncated off the end here, so it cannot be accidentally valid.

track_properties.go is now 100% with no uncovered blocks. Floors
regenerated with `make cover-floors` (pkg/moqt/session 87.2 -> 87.4); the
same run refused to lower pkg/relay 86.2 -> 86.0, which the ratchet kept
and t... (continued)

Coverage Stats

9324 of 10530 relevant lines covered (88.55%)

2.01 hits per line