floatdrop / moq-go / 31776023756
89%

DEFAULT BRANCH: draft-19
Ran
Jobs 1
Files 102
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.471% (+0.1%) from 88.357%
31776023756

push

github

floatdrop 
test(relay): cover the NAMESPACE_DONE and WantsTracks branches of the namespace watch

forwardNamespaceEvent had exactly one test driving it
(TestCrossRelay_WatchNamespacesForward), walking exactly one shape: a
successful OpPublish to a matching subscriber that does not want tracks.
Two of its branches were reached by nothing.

The OpUnpublish arm is the fea80fc shape almost exactly. OpUnpublish is
asserted on all over the suite — memory_test.go, etcd_test.go,
discovery_integration_test.go — but every one of those stops at the store
boundary, checking the event comes *out* of WatchNamespaces rather than
that the relay reflects it onward. The arm could be deleted with the
whole suite green, while a downstream subscriber silently never learned a
remote namespace had gone away.

The WantsTracks skip is the other: a SUBSCRIBE_TRACKS holder must not be
sent NAMESPACE (§6.1 — those holders get PUBLISH), and nothing checked
it. Its test pairs the SUBSCRIBE_TRACKS holder with a SUBSCRIBE_NAMESPACE
control, because a bare "nothing arrived" assertion passes just as well
when the watch never fired, the prefix never matched, or the relay never
started.

Both were verified red first, by deleting the branch each targets, and
each failed only for its own:

  removed OpUnpublish arm  -> Unpublish test FAIL (timeout on
                              NAMESPACE_DONE), skip test PASS
  removed WantsTracks skip -> skip test FAIL (unexpected
                              *message.Namespace), Unpublish test PASS

The quiet-stream assertion fails on a Parse error as well as on a
message. Without that, closing the SUBSCRIBE_TRACKS session mid-test left
it green — a dead stream is not a skipped one, and the regressions the
test exists to catch (relay resetting the stream on a namespace event,
SubscribeTracks not establishing it) all look like silence.

forwardNamespaceEvent goes 69.2% -> 92.3% of statements; what remains is
the WatchNamespaces error path and a defensive default... (continued)

9316 of 10530 relevant lines covered (88.47%)

2.01 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31776023756.1 102
88.47
 GitHub Action Run
Source Files on build 31776023756