drakenclimber / libcgroup
56%
main: 56%

LAST BUILD BRANCH: alert-autofix-11
DEFAULT BRANCH: main
Repo Added
Files 39
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH alert-autofix-11
branch: SELECT
CHANGE BRANCH
x

coverage: 56.221%. Remained the same
20936479223

push

github

drakenclimber 
api: Fix unsafe call to strncat in cgroup_get_procs() and cgroup_get_threads()

TJH - the text below was autogenerated by Copilot.

In general, when using strncat, the third argument must reflect the
remaining space in the destination buffer minus one byte to keep room
for the terminating NUL. The correct upper bound is therefore
sizeof(dest) - strlen(dest) - 1. This ensures strncat cannot write past
the end of the buffer, even including the terminator it always appends.

For this code, the minimal, behavior-preserving fix is to adjust the
strncat calls that append constant suffixes to cgroup_path.
Specifically:

In cgroup_get_procs, change FILENAME_MAX - strlen(cgroup_path) to
FILENAME_MAX - strlen(cgroup_path) - 1.
In cgroup_get_threads, make the same adjustment.
No other logic needs to change; the functions will still append the same
suffixes, but the maximum number of characters strncat is allowed to
copy will correctly reserve one byte for the NUL terminator. If
cg_build_path already fills nearly the entire buffer, the new limit
prevents overflow and may result in a truncated path; if such truncation
should be handled explicitly, additional error checks on
strlen(cgroup_path) relative to FILENAME_MAX could be added, but that
would go beyond the minimal fix requested.

These changes are all within src/api.c, in the region containing
cgroup_get_procs and cgroup_get_threads, and do not require any new
includes or helper functions.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

1 of 2 new or added lines in 1 file covered. (50.0%)

5608 of 9975 relevant lines covered (56.22%)

568.63 hits per line

Relevant lines Covered
9975 RELEVANT LINES 5608 COVERED LINES
568.63 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
20936479223 alert-autofix-11 api: Fix unsafe call to strncat in cgroup_get_procs() and cgroup_get_threads() TJH - the text below was autogenerated by Copilot. In general, when using strncat, the third argument must reflect the remaining space in the destination buffer minus... push drakenclimber github
56.22
20928938325 update-gtest bootstrap: Update to googletest v1.17.0 Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> push drakenclimber github
46.64
20928767419 update-gtest bootstrap: Update to googletest v1.14.0 Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> push drakenclimber github
52.93
20928558948 update-gtest bootstrap: Update to googletest v1.15.0 Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> push drakenclimber github
52.93
20928401962 update-gtest bootstrap: Update to googletest v1.16.0 Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> push drakenclimber github
52.93
20928234850 update-gtest bootstrap: Update to googletest v1.17.0 Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> push drakenclimber github
52.93
20927692526 alert-autofix-11 api: Fix unsafe call to strncat in cgroup_get_procs() and cgroup_get_threads() TJH - the text below was autogenerated by Copilot. In general, when using strncat, the third argument must reflect the remaining space in the destination buffer minus... push drakenclimber github
56.22
20927331892 alert-autofix-11 Potential fix for code scanning alert no. 11: Potentially unsafe call to strncat Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> push web-flow github
56.22
20927331619 alert-autofix-11 docs: update -a flag to match uid:gid order Update cgcreate's man page so that it correctly displays the order in which the uid and gid parameters are passed in. Signed-off-by: Tomas Fabrizio Orsi <torsi@fi.uba.ar> Acked-by: Kamalesh Babulal <ka... push drakenclimber github
56.22
20867085047 set-property4 ftests: Add a test for setting systemd properties via cgxset Add a functional test for setting cgroup settings via cgxset and the SetUnitProperties systemd method over D-Bus. ----------------------------------------------------------------- Test... push drakenclimber github
57.17
See All Builds (1017)