drakenclimber / libcgroup

56%

main: 56%

LAST BUILD ON BRANCH test

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 066
• 3pl
• add-cgx-man-pages
• alert-autofix-11
• allow-space-cgrules
• cgall2
• cgcompare
• cgcompare2
• cgconfigscript
• cgcreate
• cgroup-controller
• cgroup-controller-v2
• cgroup-controller-v3
• cgsos
• cgsos2
• cgsos3
• clang
• cleanup-subtree
• codeql
• consts-rework
• coverity
• dependabot
• dist-subdirs-2.0
• distro
• doc
• extra-logging
• fix-005
• fix-cgxset
• fix-rel2.0
• fix008
• fixspaces
• fixwarning
• fixwarnings
• foo
• ftest-lock
• get_next_rule_field
• getprocs
• getprocs2
• github
• github-workflow-ci
• issues/21
• issues/38
• issues/61
• issues/62
• issues/66
• issues/71
• issues/71v2
• issues/73
• issues/advanced-cgget
• issues/betterlogs
• issues/cgclear
• issues/cgclear2
• issues/cgconfig-tests
• issues/cgconfigparser
• issues/cgexec-test
• issues/cgget-refactor
• issues/cgget-refactor2
• issues/cgget-tests
• issues/cgrules
• issues/cgrules2
• issues/cgrules3
• issues/cgrules4
• issues/cgset-tests
• issues/cgsnapshot
• issues/cgsnapshot2
• issues/cgv2-tests
• issues/cgxget
• issues/cgxget3
• issues/cgxget4
• issues/cgxget5
• issues/cgxget5-pybindings
• issues/cgxget5-pybindings3
• issues/cgxget5-pybindings4
• issues/cgxget5-pybindings5
• issues/cgxget5-pybindings6
• issues/cgxget5-toolslib
• issues/codecovrel2.0
• issues/codeql
• issues/contributing
• issues/coveralls_badge
• issues/daemoncodecov
• issues/delete-cgclear
• issues/delete-legacy
• issues/distcheck
• issues/doxygen
• issues/doxygen_badge
• issues/emptycg
• issues/emptycgcreate
• issues/finalize
• issues/fix-warnings
• issues/fixcgset
• issues/fixme
• issues/fixmerge
• issues/fixtest004
• issues/fixwarnings
• issues/ftests_cgv2
• issues/github_actions
• issues/improvecodecov
• issues/kill-child
• issues/lgtm
• issues/lscgroup
• issues/lssubsys
• issues/mainbadge
• issues/mount-pybindings
• issues/nocontainer
• issues/noinst
• issues/random
• issues/readme
• issues/rel2-codeql
• issues/remove-libs
• issues/removetestsdir
• issues/threaded
• issues/update-map
• issues/v2.0.1
• issues/validate
• leaf-node
• linter
• list-cgroup-mnts-api
• main
• master
• memory_abstraction
• merge-tests
• merge-tests-3.0
• mount-table-overflow
• nosystemd-job
• options
• pids
• ps
• pull/44
• pull/45
• pull/46
• release-2.0
• release-3.0
• release-3.2
• rename-python-set-default
• rework-testing
• set-property
• set-property2
• set-property3
• set-property4
• setup_mode
• systemd
• systemd-cexample
• systemd-cgconfig
• systemd-cmdline
• systemd-pythonexample
• test
• test-reliability
• test2
• tests2
• undefsystemd
• update-gtest
• update-rel2-tests
• wip/abstract_cgget2
• wip/cgexec-test
• wip/cgset-tests
• wip/cgsnapshot
• wip/cgxget
• wip/cgxget2
• wip/cgxget3
• wip/cgxget4
• wip/delete-legacy
• wip/dist-subdirs
• wip/empty_cgcreate2
• wip/emptycgs
• wip/gh_actions
• wip/refactor_cgget2
• wip/release-2.0
• wip/systemd
• wip/systemd10
• wip/systemd11
• wip/systemd12
• wip/systemd2
• wip/systemd3
• wip/systemd4
• wip/systemd5
• wip/systemd6
• wip/systemd7
• wip/systemd8
• wip/systemd9
• wip/test-cgget.new
• wip/test-cgget.old

Build # 22957196270

Build Type

push

github

Committed by drakenclimber

Commit Message

tests/ftests: speed up is_output_same() line compare loop

is_output_same() used to call expected_out.splitlines() on every
iteration and index into the freshly built list. Switching to
enumerate(zip(out_lines, exp_lines)) lets us split both strings once
and walk the pairs directly.

A quick timeit run (1,000,000 iterations with matching output) shows
the new loop shaving ~5% off the runtime:

old: 0.18783240672200918
new: 0.1784688732586801

While tiny in absolute terms, this removes needless allocations and
makes the helper more future-proof.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Run Details

5621 of 10000 relevant lines covered (56.21%)

601.75 hits per line