drakenclimber / libcgroup
56%

DEFAULT BRANCH: main
Repo Added
Files 39
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 56.128% (-0.09%) from 56.221%
23767314410

push

github

drakenclimber 
config: pass NULL when probing systemd default cgroup

ASan reported following global-buffer-overflow:

READ of size 1 at 0x7f50dc6b3e9f thread T0
    #0 0x... in cg_concat_path <src>/src/api.c:1769
    #1 0x... in cg_build_path_locked <src>/src/api.c:1889
    #2 0x... in cg_build_path <src>/src/api.c:1910
    #3 0x.. in systemd_default_cgroup_exists <src>/src/config.c:2258
    #4 0x.. in cgroup_set_default_systemd_cgroup <src>/src/config.c:2306
    #5 0x... in main <src>/src/tools/cgdelete.c:193
    #6 0x... in __libc_start_call_main (/lib64/libc.so.6+0x2a60f)
    #7 0x... in __libc_start_main_alias_2 (/lib64/libc.so.6+0x2a6bf)
    #8 0x... in _start (/usr/local/bin/cgdelete+0x402384)

0x... sits one byte to the left of the empty string literal '.LC3' that
systemd_default_cgroup_exists() handed to cg_build_path(). Passing an
empty suffix made cg_concat_path() evaluate suf[-1] while it decided
whether to append a trailing slash, triggering the ASan
global-buffer-overflow.

Fix by passing NULL, instead of "" (empty string) so cg_build_path()
skips the suffix concatenation entirely. The resulting canonical paths
are unchanged, but cgdelete (and any other caller) now runs without
trampling the adjacent literal.

Fixes: https://github.com/libcgroup/libcgroup/issues/526
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

1 of 1 new or added line in 1 file covered. (100.0%)

1207 existing lines in 4 files now uncovered.

5633 of 10036 relevant lines covered (56.13%)

584.4 hits per line

Relevant lines Covered
10036 RELEVANT LINES 5633 COVERED LINES
584.4 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
23767314410 main config: pass NULL when probing systemd default cgroup ASan reported following global-buffer-overflow: READ of size 1 at 0x7f50dc6b3e9f thread T0 #0 0x... in cg_concat_path <src>/src/api.c:1769 #1 0x... in cg_build_path_locked <src>/src/a... push drakenclimber github
56.13
20863027504 main docs: update -a flag to match uid:gid order Update cgcreate's man page so that it correctly displays the order in which the uid and gid parameters are passed in. Signed-off-by: Tomas Fabrizio Orsi <torsi@fi.uba.ar> Acked-by: Kamalesh Babulal <ka... push drakenclimber github
56.22
16274360949 main ftests/cgroup: Add timeout to cgrulesengd cgrulesengd -n (nodaemon mode) runs indefinitely until it is terminated with SIGKILL. To handle this, introduce a 20-second timeout that is passed to __run(), which in turn calls subproc.kill() to termina... push drakenclimber github
56.18
16273229335 main ftests: Fix false positive in 013 testcase Fix the false positive in the testcase number 013, the return value should be by default TEST_FAILED, instead of TEST_PASSED. The flow of the testcase is designed to set the return value to TEST_PASSED o... push drakenclimber github
56.22
16178979042 main api.c: prevent array out-of-bounds access in cgroup_parse_rules_file In the function src/api.c/cgroup_parse_rules_file, the condition of loop: for (i = 0; lst->tail->controllers[i]; i++) cgroup_dbg(" %s", lst->tail->controllers[i]); all... push drakenclimber github
54.02
15215071854 main tests: fix checking wrong result in 017-API_fuzz_test There seem to be various calls to cgroup_add_controller where the result isn't validated, instead checking the cgrp pointer. We could add two asserts in each place being changed here if the c... push drakenclimber github
56.22
14885439003 main ftests: Add a test for the memory abstraction layer Add a test for the memory abstraction layer abstractions. Currently only supports: memory.max <-> memory.limit_in_bytes memory.high <-> memory.soft_limit_in_bytes ------... push kamalesh-babulal github
56.16
14407600166 main github: dist: Rework the unit tests Add a configure option to enable/disable the unit tests. Because of their dependency upon googletest, they're very difficult to run for distros. This allows them to packaged with libcgroup, but they are disable... push kamalesh-babulal github
56.09
14344543685 main src/daemon/cgrulesengd: Correctly check for ENOBUFS when doing recvfrom() Currently, code checks if recvfrom() returns ENOBUFS, however, it can never return errno type error code, but -1 on error Fix that by checking errno in case of an error in... push drakenclimber github
59.65
14227208070 main googletest: Update to use version 1.2.0 Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> Acked-by: Kamalesh Babulal <kamalesh.babulal@oracle.com> push drakenclimber github
59.6
See All Builds (1028)