dblock / ruby-enum

100%

master: 100%

LAST BUILD ON BRANCH fix-values-override-issue-62

branch: fix-values-override-issue-62

CHANGE BRANCH

x

Reset

• fix-values-override-issue-62
• HEAD
• dblock/coveralls-github-token
• document-performance
• fix-subclass-no-defines
• master
• memoize-enum-hash
• rename-ruby-namespace
• replace-code-climate-with-coveralls
• ruby-4.0
• subclass-inherited-values
• update-copyright-year

Build # #40

Build Type

Pull #63

Committed by dblock

Commit Message

Fix values, value? and key returning a superclass' overridden value (#62)

values, value? and key each had their own logic for merging a
subclass' enums with its superclass', instead of using the
memoized, deduping _enum_hash used by to_h, keys, key?, value,
parse and each.

values did a recursive list concatenation (superclass.values +
result), so a subclass redefining a parent's key showed both the
parent's stale value and its own override.

value? and key relied on _enums_by_value, a hash merged by value
rather than by key, so a superclass' stale value=>enum mapping for
an overridden key was never overwritten (it's a different hash
key), leaving value?/key returning true/the key for values that no
longer belong to that key.

Fixed by:
* values now reads from _enum_hash like every other method.
* _enums_by_value is now derived from _enum_hash (keyed by key)
  instead of merged directly by value, so overridden keys can't
  leave stale by-value entries behind.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Pull Request Pull Request #63: Fix values including a superclass' overridden value

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

157 of 157 relevant lines covered (100.0%)

6.55 hits per line