dblock / ruby-enum

100%

master: 100%

LAST BUILD ON BRANCH fix-subclass-no-defines

branch: fix-subclass-no-defines

CHANGE BRANCH

x

Reset

• fix-subclass-no-defines
• HEAD
• dblock/coveralls-github-token
• document-performance
• fix-values-override-issue-62
• master
• memoize-enum-hash
• rename-ruby-namespace
• replace-code-climate-with-coveralls
• ruby-4.0
• subclass-inherited-values
• update-copyright-year

Build # #18

Build Type

Pull #58

Committed by dblock

Commit Message

Fix NoMethodError when a subclass defines no enums of its own

Ruby::Enum's class methods (keys, values, key?, value?, key, value,
to_h, parse, each) relied directly on @_enum_hash/@_enums_by_value
instance variables, which are only set the first time define is
called. A subclass that includes Ruby::Enum only through inheritance
and never calls define itself never gets these ivars set, so calling
any of the above methods raised NoMethodError on nil.

Introduces private _enum_hash/_enums_by_value reader methods that
default to an empty hash, and uses them everywhere instead of the raw
instance variables.

Closes #49.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Pull Request Pull Request #58: Fix NoMethodError on enum methods when subclass defines no enums of its own

Coverage Stats

18 of 18 new or added lines in 1 file covered. (100.0%)

152 of 152 relevant lines covered (100.0%)

6.51 hits per line