databendlabs / openraft / 22723756593

87%

Build Type

push

github

Committed by drmingdrmer

Commit Message

change: in 0.10.0: `RaftLeaderId<C>` to `RaftLeaderId<Term, NID>` to break circular type dependency

`RaftLeaderId` only uses `C::Term` and `C::NodeId` from `RaftTypeConfig`,
so replace the single `C` parameter with two independent type parameters.
This eliminates the circular dependency:
`RaftTypeConfig::LeaderId: RaftLeaderId<Self>` → `RaftLeaderId<C>` → back.

Changes:
- `RaftLeaderId<C>` → `RaftLeaderId<Term, NID>`
- `LeaderId<C>` → `LeaderId<Term, NID>` (both std and adv)
- `CommittedLeaderId<C>` → `CommittedLeaderId<Term>` (std) / `CommittedLeaderId<Term, NID>` (adv)
- `LeaderIdCompare<C>` → `LeaderIdCompare<Term, NID>`
- `RaftTypeConfig::LeaderId: RaftLeaderId<Self>` → `RaftLeaderId<Self::Term, Self::NodeId>`

Upgrade tip:

Update `RaftLeaderId` implementations from 1 type parameter to 2:
- `impl RaftLeaderId<C> for MyLeaderId<C>` → `impl RaftLeaderId<Term, NID> for MyLeaderId<Term, NID>`
- `LeaderId<Self>` in `declare_raft_types!` → `LeaderId<Self::Term, Self::NodeId>`

Coverage Stats

72 of 73 new or added lines in 7 files covered. (98.63%)

8 existing lines in 1 file now uncovered.

15862 of 18077 relevant lines covered (87.75%)

146378.89 hits per line