collectiveidea / delayed_job

90%

master: 92%

LAST BUILD ON BRANCH idempotent_instantiation

branch: idempotent_instantiation

CHANGE BRANCH

x

Reset

• idempotent_instantiation
• bring-back-3
• check-test
• cleanup-test-versions
• code-reloading
• master
• separate-yaml
• update-testing-dependency-versions
• v4.0.2
• v4.0.3
• v4.0.4
• v4.0.5
• v4.0.6
• v4.1.1
• v4.1.2

Build # 432

Build Type

push

travis-ci

Committed by brianhempel

Commit Message

Make Delayed::Worker.new idempotent 

Calling Delayed::Worker.new multiple times would continue to re-add the
plugins to the lifecycle.

Some gems and projects use the pattern `Delayed::Worker.new.work_off` to
trigger delayed jobs in specs. Over time, the callback chain would get
very long and, in our case, caused a StackLevelTooDeep error.

Better would be to have a proper singleton: 

`Delayed::Worker.worker.work_off`

In the absence of a proper singleton, this will make the pattern work.

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

917 of 1023 relevant lines covered (89.64%)

740.72 hits per line