432
90%
master: 92%

Ran 30 Jan 2015 06:47PM UTC

Jobs 41

Files 16

Run time 20min

Badge

Embed ▾

pending completion

Build # 432

Build Type

push

travis-ci

Committed by

brianhempel

Commit Message

Make Delayed::Worker.new idempotent 

Calling Delayed::Worker.new multiple times would continue to re-add the
plugins to the lifecycle.

Some gems and projects use the pattern `Delayed::Worker.new.work_off` to
trigger delayed jobs in specs. Over time, the callback chain would get
very long and, in our case, caused a StackLevelTooDeep error.

Better would be to have a proper singleton: 

`Delayed::Worker.worker.work_off`

In the absence of a proper singleton, this will make the pattern work.

Run Details

8 of 8 new or added lines in 1 file covered. (100.0%)

917 of 1023 relevant lines covered (89.64%)

740.72 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
19	86.84	0.0%	lib/delayed/worker.rb

Jobs

ID	Job ID	Ran	Files	Coverage
1	432.1 (1.9.3, RAILS_VERSION="~> 3.0.0")	30 Jan 2015 06:47PM UTC	16	89.34	Travis Job 432.1
2	432.2 (2.0.0, RAILS_VERSION="~> 3.0.0")	30 Jan 2015 06:48PM UTC	16	89.34	Travis Job 432.2
3	432.3 (2.1, RAILS_VERSION="~> 3.0.0")	30 Jan 2015 06:48PM UTC	16	88.92	Travis Job 432.3
4	432.4 (jruby-19mode, RAILS_VERSION="~> 3.0.0")	30 Jan 2015 06:50PM UTC	16	89.72	Travis Job 432.4
5	432.5 (jruby-head, RAILS_VERSION="~> 3.0.0")	30 Jan 2015 06:51PM UTC	16	89.4	Travis Job 432.5
6	432.6 (rbx-2, RAILS_VERSION="~> 3.0.0")	30 Jan 2015 06:52PM UTC	13	94.3	Travis Job 432.6
7	432.7 (ruby-head, RAILS_VERSION="~> 3.0.0")	30 Jan 2015 06:51PM UTC	16	88.92	Travis Job 432.7
8	432.8 (1.9.3, RAILS_VERSION="~> 3.1.0")	30 Jan 2015 06:51PM UTC	16	89.13	Travis Job 432.8
9	432.9 (2.0.0, RAILS_VERSION="~> 3.1.0")	30 Jan 2015 06:51PM UTC	16	89.34	Travis Job 432.9
10	432.10 (2.1, RAILS_VERSION="~> 3.1.0")	30 Jan 2015 06:53PM UTC	16	89.13	Travis Job 432.10
11	432.11 (jruby-19mode, RAILS_VERSION="~> 3.1.0")	30 Jan 2015 06:54PM UTC	16	89.8	Travis Job 432.11
12	432.12 (jruby-head, RAILS_VERSION="~> 3.1.0")	30 Jan 2015 06:56PM UTC	16	89.48	Travis Job 432.12
13	432.13 (rbx-2, RAILS_VERSION="~> 3.1.0")	30 Jan 2015 06:57PM UTC	13	95.26	Travis Job 432.13
14	432.14 (ruby-head, RAILS_VERSION="~> 3.1.0")	30 Jan 2015 06:55PM UTC	16	89.13	Travis Job 432.14
15	432.15 (1.9.3, RAILS_VERSION="~> 3.2.0")	30 Jan 2015 06:55PM UTC	16	89.34	Travis Job 432.15
16	432.16 (2.0.0, RAILS_VERSION="~> 3.2.0")	30 Jan 2015 06:56PM UTC	16	89.34	Travis Job 432.16
17	432.17 (2.1, RAILS_VERSION="~> 3.2.0")	30 Jan 2015 06:56PM UTC	16	89.13	Travis Job 432.17
18	432.18 (jruby-19mode, RAILS_VERSION="~> 3.2.0")	30 Jan 2015 06:58PM UTC	16	89.8	Travis Job 432.18
19	432.19 (jruby-head, RAILS_VERSION="~> 3.2.0")	30 Jan 2015 06:59PM UTC	16	89.48	Travis Job 432.19
20	432.20 (rbx-2, RAILS_VERSION="~> 3.2.0")	30 Jan 2015 06:59PM UTC	13	95.26	Travis Job 432.20
21	432.21 (ruby-head, RAILS_VERSION="~> 3.2.0")	30 Jan 2015 06:58PM UTC	16	89.13	Travis Job 432.21
22	432.22 (1.9.3, RAILS_VERSION="~> 4.0.0")	30 Jan 2015 06:58PM UTC	16	89.34	Travis Job 432.22
23	432.23 (2.0.0, RAILS_VERSION="~> 4.0.0")	30 Jan 2015 06:59PM UTC	16	89.34	Travis Job 432.23
24	432.24 (2.1, RAILS_VERSION="~> 4.0.0")	30 Jan 2015 06:59PM UTC	16	89.13	Travis Job 432.24
25	432.25 (jruby-19mode, RAILS_VERSION="~> 4.0.0")	30 Jan 2015 07:00PM UTC	16	89.51	Travis Job 432.25
26	432.26 (jruby-head, RAILS_VERSION="~> 4.0.0")	30 Jan 2015 07:02PM UTC	16	89.4	Travis Job 432.26
27	432.27 (rbx-2, RAILS_VERSION="~> 4.0.0")	30 Jan 2015 07:03PM UTC	13	95.06	Travis Job 432.27
28	432.28 (ruby-head, RAILS_VERSION="~> 4.0.0")	30 Jan 2015 07:01PM UTC	16	89.13	Travis Job 432.28
29	432.29 (1.9.3, RAILS_VERSION="~> 4.1.0")	30 Jan 2015 07:01PM UTC	16	89.34	Travis Job 432.29
30	432.30 (2.0.0, RAILS_VERSION="~> 4.1.0")	30 Jan 2015 07:01PM UTC	16	89.34	Travis Job 432.30
31	432.31 (2.1, RAILS_VERSION="~> 4.1.0")	30 Jan 2015 07:01PM UTC	16	89.13	Travis Job 432.31
32	432.32 (jruby-19mode, RAILS_VERSION="~> 4.1.0")	30 Jan 2015 07:03PM UTC	16	89.79	Travis Job 432.32
33	432.33 (jruby-head, RAILS_VERSION="~> 4.1.0")	30 Jan 2015 07:04PM UTC	16	89.47	Travis Job 432.33
34	432.34 (rbx-2, RAILS_VERSION="~> 4.1.0")	30 Jan 2015 07:05PM UTC	13	95.15	Travis Job 432.34
35	432.35 (ruby-head, RAILS_VERSION="~> 4.1.0")	30 Jan 2015 07:03PM UTC	16	89.13	Travis Job 432.35
36	432.36 (1.9.3, RAILS_VERSION="~> 4.2.0")	30 Jan 2015 07:04PM UTC	16	89.34	Travis Job 432.36
37	432.37 (2.0.0, RAILS_VERSION="~> 4.2.0")	30 Jan 2015 07:05PM UTC	16	89.34	Travis Job 432.37
38	432.38 (2.1, RAILS_VERSION="~> 4.2.0")	30 Jan 2015 07:05PM UTC	16	89.13	Travis Job 432.38
39	432.39 (jruby-19mode, RAILS_VERSION="~> 4.2.0")	30 Jan 2015 07:05PM UTC	16	89.79	Travis Job 432.39
40	432.40 (jruby-head, RAILS_VERSION="~> 4.2.0")	30 Jan 2015 07:07PM UTC	16	89.47	Travis Job 432.40
42	432.42 (ruby-head, RAILS_VERSION="~> 4.2.0")	30 Jan 2015 07:07PM UTC	16	88.92	Travis Job 432.42

Source Files on build 432

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

collectiveidea / delayed_job / 432
90%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 432

collectiveidea / delayed_job / 432 90% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 432

collectiveidea / delayed_job / 432
90%
master: 92%

README BADGES
x