carapace-sh / carapace

58%

master: 58%

LAST BUILD ON BRANCH uid-threadsafe

branch: uid-threadsafe

CHANGE BRANCH

x

Reset

Sync Branches

• uid-threadsafe
• action-context
• action-uid
• action-unique
• action-unlessf
• actionPath-fix-symlinks
• actionexecutables-dirs
• actionflags-split-tag
• actions-container
• add-description-length-env
• assert-pkg
• autofix-lint-hints
• bash-fix-homedir-space
• bash-fix-placeholder
• bash-snippet
• bash-xargs-calls
• ble-detect
• clink-snippet
• cmd-clink
• completer-interface
• compose-tcsh
• context-abs-fix-home
• defaultactions-slim
• dependabot-automerge
• dependabot/github_actions/actions/cache-5
• dependabot/github_actions/actions/checkout-5
• dependabot/github_actions/actions/checkout-6
• dependabot/github_actions/actions/download-artifact-5
• dependabot/github_actions/actions/download-artifact-6
• dependabot/github_actions/actions/download-artifact-7
• dependabot/github_actions/actions/setup-go-6
• dependabot/github_actions/actions/upload-artifact-5
• dependabot/github_actions/actions/upload-artifact-6
• dependabot/github_actions/actions/upload-artifact-7
• dependabot/github_actions/github/codeql-action-4
• dependabot/github_actions/golangci/golangci-lint-action-5
• dependabot/github_actions/golangci/golangci-lint-action-6
• dependabot/github_actions/golangci/golangci-lint-action-7
• dependabot/github_actions/golangci/golangci-lint-action-8
• dependabot/github_actions/golangci/golangci-lint-action-9
• dependabot/github_actions/goreleaser/goreleaser-action-6
• dependabot/github_actions/goreleaser/goreleaser-action-7
• dependabot/go_modules/github.com/carapace-sh/carapace-shlex-1.0.0
• dependabot/go_modules/github.com/carapace-sh/carapace-shlex-1.0.1
• dependabot/go_modules/github.com/carapace-sh/carapace-shlex-1.1.0
• dependabot/go_modules/github.com/carapace-sh/carapace-shlex-1.1.1
• dependabot/go_modules/github.com/spf13/cobra-1.10.2
• dependabot/go_modules/github.com/spf13/cobra-1.8.1
• dependabot/go_modules/github.com/spf13/cobra-1.9.1
• dependabot/go_modules/github.com/spf13/pflag-1.0.10
• dependabot/go_modules/github.com/spf13/pflag-1.0.6
• dependabot/go_modules/github.com/spf13/pflag-1.0.7
• dependabot/go_modules/github.com/spf13/pflag-1.0.9
• devcontainer-fix-env
• diff-patch
• diff-sort
• doc-envsubst
• doc-export-lowercase
• doc-fix-link
• doc-mv-envsubst
• doc-rm-introduction
• doc-typo
• doc-update-theme
• docker-font
• docker-nushell
• docker-update-version
• docker-update-versions
• docker-vhs-sandbox
• docs-vhs
• elvish-exe-completion
• elvish-filter-tab
• embed-jsonc
• env-fix-check
• env-hidden-granular
• env-mergeflags
• env-nospace
• env-unfiltered
• envsubst-skippable
• envsubst-test
• file-query
• fish-erase
• fish-local-var
• fish-reduce-xargs
• fish-snippet
• fix-codespace
• fix-hints
• fix-lint
• fix-multiparts
• fix-overlap
• fix-release
• flagset-exclusive-self
• goreleaser-defaults
• issue-label-policy
• issue-labeler
• master
• match-fix-equal
• nushell-alias-expansion
• oil-link
• patch-1
• powershell-exe
• powershell-list
• powershell-nocolor
• powershell-tooltip
• query
• query-param
• refs/tags/v1.0.0
• refs/tags/v1.1.0
• refs/tags/v1.1.1
• refs/tags/v1.1.2
• refs/tags/v1.1.3
• refs/tags/v1.1.4
• refs/tags/v1.1.5
• refs/tags/v1.1.6
• refs/tags/v1.10.0
• refs/tags/v1.10.1
• refs/tags/v1.10.2
• refs/tags/v1.10.3
• refs/tags/v1.11.0
• refs/tags/v1.11.1
• refs/tags/v1.11.2
• refs/tags/v1.11.3
• refs/tags/v1.11.4
• refs/tags/v1.11.5
• refs/tags/v1.11.6
• refs/tags/v1.2.0
• refs/tags/v1.3.0
• refs/tags/v1.3.1
• refs/tags/v1.3.2
• refs/tags/v1.3.3
• refs/tags/v1.4.0
• refs/tags/v1.5.0
• refs/tags/v1.5.1
• refs/tags/v1.5.2
• refs/tags/v1.5.3
• refs/tags/v1.6.0
• refs/tags/v1.6.1
• refs/tags/v1.7.1
• refs/tags/v1.8.0
• refs/tags/v1.8.1
• refs/tags/v1.8.2
• refs/tags/v1.8.3
• refs/tags/v1.8.4
• refs/tags/v1.8.5
• refs/tags/v1.8.6
• refs/tags/v1.8.7
• refs/tags/v1.9.0
• refs/tags/v1.9.1
• revert-1105-dependabot/go_modules/github.com/spf13/pflag-1.0.6
• rm-docker
• special-test
• stripansi-ondemand
• support-duplicates
• template-cmd
• testmain
• traverse-fix-gobindir
• traverse-golang
• traverse-nix-profile
• uid-context
• uid-gcompat
• uid-pathescape
• uid-persistentflag
• uid-uidf
• update-actions
• update-compose
• update-devcontainer
• update-go
• update-linke
• update-package
• update-pflag
• update-readme
• update-template
• update-templates
• update-versions
• vhs
• vhs-backup2
• vhs-basic
• vhs-doublequoteopen
• vhs-escape
• vhs-escape-powershell
• vhs-fix-nushell
• vhs-fix-tape
• vhs-missing-action
• vhs-redirect
• vhs-singlequote
• vhs-singlequoteopen
• vhs-special
• vhs-special-quoted
• vhs-xonsh
• workflow-dependency
• xdg-relative
• xonsh-fix-empty-result
• xonsh-fix-import
• xonsh-fix-script
• zsh-fix-alias
• zsh-fix-fullyquoted
• zsh-fix-quote
• zsh-fix-quoted
• zsh-fix-quotingstate
• zsh-flags-tag
• zsh-placeholder
• zsh-slice-words
• zsh-snippet
• zsh-suffix
• zsh-xargs-calls

Build # 26375828229

Build Type

Pull #1224

github

Committed by rsteube

Commit Message

uid: fix race condition in Flag() by holding mutex during recursion

The mutex was previously only held during the initial LocalFlags() call,
but the recursive traversal to parent commands happened outside the lock.
This could cause concurrent map write issues when multiple goroutines
called Flag() simultaneously.

Now uses a helper function flagRecursive() that stays within the mutex
for the entire operation.

Assisted-by: Crush:minimax-m2.7

Pull Request Pull Request #1224: uid: fix race condition in Flag() by holding mutex during recursion

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

3290 of 5655 relevant lines covered (58.18%)

1.02 hits per line