carapace-sh / carapace / 26375828229

58%

master: 58%

Pull #1224

github

uid: fix race condition in Flag() by holding mutex during recursion

The mutex was previously only held during the initial LocalFlags() call,
but the recursive traversal to parent commands happened outside the lock.
This could cause concurrent map write issues when multiple goroutines
called Flag() simultaneously.

Now uses a helper function flagRecursive() that stays within the mutex
for the entire operation.

Assisted-by: Crush:minimax-m2.7

7 of 7 new or added lines in 1 file covered. (100.0%)

3290 of 5655 relevant lines covered (58.18%)

1.02 hits per line