broadinstitute / gamgee

93%

master: %

LAST BUILD ON BRANCH jt_mvr_fixes

branch: jt_mvr_fixes

CHANGE BRANCH

x

Reset

• jt_mvr_fixes
• mc_coveralls
• master
• jt_misc_fixes
• ks_genotype_field_value
• bh_select_if_doc
• mc_contig_renaming
• mc_add_sam_tests
• mc_contigs_highlander
• dr_monolithic_gamgee_header
• mc_zip_iterator
• jt_pqueue
• mc_update_boundary_checks
• ak_n_samples_error
• dr_remove_header_deep_copying
• ks_genotype_field_value_jul_17
• htslib_revup
• ks_genotype_field_value_jul_22
• ks_genotype_field_value_jul_23
• ks_genotype_field_value_jul_24
• mc_fix_n_samples
• mc_variant_id_field
• ks_genotype_field_value_jul_25
• mc_variant_string_format_field_fix
• mc_missing_string_value
• mc_include_guards
• mc_build_release_by_default
• mc_website_dox_update
• jt_ref_block_traversal
• mc_sam_header_fixes
• mc_more_tests
• dr_rename_samtag_is_missing
• jt_mvr_optimization
• mc_fix_variant_field_iterators
• mc_rename_info_and_format
• mc_fix_filter_unpacking
• mc_eliminate_is
• mc_missing_vector_105
• mc_api_docs_158
• mc_reimplement_shared_fields
• jt_single_reader_vectors
• ks_index_based_access_for_shared_and_individual_fields_aug_12
• jt_ref_block_mc
• jt_parse_rlen
• ks_interval_sam_iteration_using_indexed_files_aug_14
• mc_eliminate_gq_and_pl
• jt_alignment_stop
• mc_add_field_conversion_api_175
• jt_ref_block
• mc_index_based_api_162
• mc_mate_alignment_stop
• mc_refactor_fetch_next_record_192
• jt_variant_intervals
• ks_interval_sam_iteration_using_indexed_files_issue_7
• mc_operator_equals_shared_186
• mc_individual_operator_equals_187
• jt_bcf_close
• mc_interval_support_163
• mc_random_cleanups
• mc_rename_format_field_type_171
• mc_centralize_exceptions_170
• jt_raw_pointer_removal
• mc_generic_test_utils_206
• jt_mvr_nondeterminism
• jt_mvr_126
• jt_rbs
• db_iterator_patch
• ks_non_ref_het_211
• mc_insert_size
• jt_gitignore
• bh_vimbup_gitignore
• jt_synced
• jt_sync_no_intervals
• jt_sync_cache_headers
• lb_rename_alleles_keys
• jt_rbs_v6
• bh_IndividualFieldValueIterator_minus
• jt_comments
• jt_allele_strings
• jt_gamgee_h
• jt_api_226
• jt_compression_161
• jt_rbs_v7
• jt_front_back
• jt_rbs_v8
• jt_VariantHeaderBuilder_212
• intel_int_cast_missing_end_fix
• jt_ref_api
• jt_field_type
• dr_variant_builder
• intel_signed_comparison_fixes
• intel_signed_comparison
• dr_fix_float_missing_check
• jt_misc
• jt_rbs_v9
• mc_readme_updates_for_blog
• mc_expunge_copy_then_move
• jt_rbs_v10
• mc_banish_all_const_member_variables
• jt_individual_field_value_missing
• mc_snps_and_indels
• mc_travis_experiments
• lb_277_move_interval_changes_to_gamgee
• jt_tsca_tiling_const
• lb_276_add_interval_accessor
• intel_vector_end
• jt_move_field_type
• mc_relase_mode_testing
• jt_rbs_vb2
• jt_variant_header_merge
• dr_variant_header_builder_case_sensitivity_bug
• jt_rbs_vb
• dr_fix_genotype_handling_of_vector_end
• db_read_groups
• jt_vh_sample_index
• mc_remove_ycm_files
• ak_fix_samples_to_include_in_variant_reader
• ak_hadle_samples_in_variant_reader
• ak_ignore_emacs_temporaries
• intel_test_branch
• intel_clang_fix
• jt_rbs_checkpoint_1
• mc_cmake_clion
• dr_fix_IndividualFieldValue_missing
• dr_variant_missing_function
• dr_variantreader_fix_segfault_on_nonexistent_file
• dr_fix_additional_reader_segfaults_on_nonexistent_files
• dr_copy_foghorn_submodule_update_script
• dr_rev_htslib_and_remove_synced_reader_hack
• jt_kg_rbs
• mc_travis_update_cmake
• boost-build
• dr_rev_htslib_nov6
• dr_remove_obsolete_call_in_merge_variant_headers
• intel_individual_field_value_iterator_increment
• jt_pending_vector
• dr_fix_genotype_encoding_of_vector_ends
• jt_rbs_updates
• dr_improve_variant_builder_doxygen
• intel_boost-build
• intel_iterator_inc_dec
• intel_var_header_merger
• jt_tmp_pq
• jt_vr_test_cleanup
• dr_vb_flattened_vector_helper_functions
• jt_sparse_SVI
• jt_unsigned
• dr_vb_auto_encode_genotypes
• intel_multi_iterator_fix
• jt_file_index
• dr_fix_includes_in_merged_lut
• intel_whitespace_fix
• ldg_updateReadme
• jt_max_field
• dr_test_multi_sample_vector_with_max_size_zero
• dr_prevent_gt_field_set_using_integer_setters
• intel_resize_lut
• jt_directories
• dr_VariantBuilderMultiSampleVector_bounds_checking
• intel_header_field_length
• jt_travis
• jt_readme

1. Modified operator == in IndividualFieldValue to use iterators which
take care of bcf_*_vector_end values implicitly
A more serious bug in the previous implementation of the == operator was
in the way string fields were handled. Points to remember for string
fields:
a. The size() function returns the number of characters allocated for the string.
b. The variable m_num_bytes also stores the number of characters
allocated for the string (same as size())
c. When operator[i] is called for string fields, the address that is
accessed is m_format_ptr->p + i*m_num_bytes (not m_format_ptr->p + i).
The address accessed is outside the original allocated memory.

Moral of the story: use iterators always, or remember the intricacies of
string v/s other types of fields.

Similar fix for SharedField also

2. Use references to avoid copies where possible as per David's
suggestions
3. Specialized operator[] for IndividualFieldValue<string> and
SharedField<string> so that if the original VCF field type is of type
String, the index argument for operator [] cannot be greater than 0. If
it is greater than 0, then an out_of_range exception is thrown.

3. Added extra out of bounds test cases (by catching exceptions)

4. Fixed a memory leak in file_utils.h