block / mysql

84%

master: 85%

LAST BUILD ON BRANCH fork/module-path

branch: fork/module-path

CHANGE BRANCH

x

Reset

Sync Branches

• fork/module-path
• codex/readme-fork-table
• codex/reset-transactions
• feat/always-reject-read-only
• feat/rds-auto-tls
• master
• unified-query
• warning-count

Build # 34057393127

Build Type

Pull #3

github

Committed by morgo

Commit Message

Address review: pin the fork's identity, finish the README repointing

Four items from the review on #3:

1. "Linking both drivers" documented the errors.As type-identity hazard but not
   the one that mirrors this PR's own thesis: with both drivers linked, a call
   site still saying sql.Open("mysql", ...) resolves to upstream and keeps
   working, until something reaches for QueryResultContext or Warnings()
   through (*sql.Conn).Raw. Everything else in the both-linked surface fails
   loudly (the registries are package-level globals and name the cause on use),
   so the one silent case is worth naming.

2. Nothing pinned the two lines this PR consists of. Both mutations — the
   driver name back to "mysql", the module path back to upstream's — build
   clean and pass the full suite, and they are exactly the two places every
   `git merge upstream/master` has a conflict to resolve. fork_test.go asserts
   both: debug.ReadBuildInfo().Main.Path reads the real go.mod rather than a
   copy, and sql.Drivers() reads what init actually registered. Verified it
   kills both mutations.

3. The LOAD DATA LOCAL INFILE section still had `import
   "github.com/go-sql-driver/mysql"` — the one copy-pasteable import left on
   the old path, in the section whose premise is needing the package directly.
   Following it registers a local file in upstream's fileRegister while
   connections come from block-mysql. Its godoc link now points at the fork,
   which documents the fork's additions too; the remaining upstream links are
   provenance and stay.

4. "5 CI jobs rather than 25" was wrong. Ran the workflow's matrix generator at
   both revisions: 21 base combinations + 2 appended include entries = 23 test
   jobs before, 3 + 2 = 5 after.

Pull Request Pull Request #3: Make this a real fork: module path github.com/block/mysql, driver name block-mysql

Coverage Stats

3538 of 4190 relevant lines covered (84.44%)

334367.21 hits per line